Page MenuHomePhabricator
Create Task
Maniphest T412605

test_https_cert_error method of http_tests.HttpsCertificateTestCase fails with threadfree Python
Closed, ResolvedPublic
Actions

Description

======================================================================
FAIL: test_https_cert_error (tests.http_tests.HttpsCertificateTestCase.test_https_cert_error)
Test if http.fetch respects disabled ssl certificate validation.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/pywikibot/pywikibot/tests/http_tests.py", line 118, in test_https_cert_error
    self.assertIn('InsecureRequestWarning',
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
                  [w.category.__name__ for w in warning_log])
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'InsecureRequestWarning' not found in []

Probablly urllib3 or requests does not support it yet.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Revert "tests: decorate HttpsCertificateTestCase as expectedFailure if THREADING_FREE"pywikibot/coremaster+2 -3
tests: decorate HttpsCertificateTestCase as expectedFailure if THREADING_FREEpywikibot/coremaster+11 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Xqt created this task.Dec 13 2025, 5:45 PM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptDec 13 2025, 5:45 PM
Xqt added a parent task: T412603: Several tests fails with threading free Python.Dec 13 2025, 5:47 PM
Xqt added a parent task: T129368: Usages of unittest.expectedFailure or unittest.skip should be solved (goal).
gerritbot added a comment.Dec 13 2025, 5:50 PM

Change #1217834 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] tests: decorate HttpsCertificateTestCase as expectedFailure if THREADING_FREE

https://gerrit.wikimedia.org/r/1217834

gerritbot added a project: Patch-For-Review.Dec 13 2025, 5:50 PM
Xqt updated the task description. (Show Details)Dec 13 2025, 5:55 PM
gerritbot added a comment.Dec 13 2025, 6:29 PM

Change #1217834 merged by jenkins-bot:

[pywikibot/core@master] tests: decorate HttpsCertificateTestCase as expectedFailure if THREADING_FREE

https://gerrit.wikimedia.org/r/1217834

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2025, 6:30 PM
Xqt triaged this task as Medium priority.Dec 14 2025, 12:02 PM
Xqt added a comment.Sun, May 17, 1:38 PM

Tests passes now with CPython (3.14.5t) and CPython (3.13.13t)

======================================================================
UNEXPECTED SUCCESS: test_https_cert_error (tests.http_tests.HttpsCertificateTestCase.test_https_cert_error)
Test if http.fetch respects disabled ssl certificate validation.
----------------------------------------------------------------------
gerritbot added a comment.Tue, May 26, 3:38 PM

Change #1293755 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] Revert "tests: decorate HttpsCertificateTestCase as expectedFailure if THREADING_FREE"

https://gerrit.wikimedia.org/r/1293755

gerritbot added a project: Patch-For-Review.Tue, May 26, 3:38 PM
gerritbot added a comment.Tue, May 26, 4:03 PM

Change #1293755 merged by jenkins-bot:

[pywikibot/core@master] Revert "tests: decorate HttpsCertificateTestCase as expectedFailure if THREADING_FREE"

https://gerrit.wikimedia.org/r/1293755

Maintenance_bot removed a project: Patch-For-Review.Tue, May 26, 4:31 PM
Xqt closed this task as Resolved.Wed, May 27, 7:00 AM
Xqt claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits