Details
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| Remove unused downstream-only function | repos/phabricator/phabricator!126 | pppery | patch-1 | wmf/stable |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Pppery | T412650 Update phabricator translations for upstream i18n changes | |||
| Open | Pppery | T412651 Make WMF translations extension pass `bin/i18n validate` |
Event Timeline
Change #1217873 had a related patch set uploaded (by Pppery; author: Pppery):
[phabricator/translations@wmf/stable] Add an internal translation file for this repo's own strings
Change #1217872 had a related patch set uploaded (by Pppery; author: Pppery):
[phabricator/translations@wmf/stable] Rm "translations" into English
Change #1217873 merged by Aklapper:
[phabricator/translations@wmf/stable] Add an internal translation file for this repo's own strings
Change #1217872 merged by Aklapper:
[phabricator/translations@wmf/stable] Rm "translations" into English
There is more to do here (adding locale files for a bunch of languages), but there's no point in doing it until WMF pulls in the upstream that actually contains bin/i18n validate so I have a steady state to base it off of.
Change #1221224 had a related patch set uploaded (by Pppery; author: Pppery):
[phabricator/translations@wmf/stable] [Don't merge yet] Add locales for all remaining languages
(This is still nowhere close to done; it needs, in addition to the above patch being merged, an import/export on the translatewiki.net side, probably a bit of manual cleanup of stuff on my side, and another export)
Change #1221224 merged by Aklapper:
[phabricator/translations@wmf/stable] Add locales for all remaining languages
Current validation errors: P94100
Still needs another export/generate cycle.
I also see a few more missing locales, and a few malformed strings.
As of https://gerrit.wikimedia.org/r/c/phabricator/translations/+/1309254:
That's a lot better. I see several classes of errors here:
- Upstream deleted source strings - needs https://gerrit.wikimedia.org/r/c/phabricator/translations/+/1309254 to be deployed to translatewiki and generated.
- Missing locale files. These need manual work, and it's going to be a pain to keep up with them but I'll manage.
- Bad plurals in a few strings on translatewiki.
- Bad interpolations in a few cases.
Change #1309266 had a related patch set uploaded (by Pppery; author: Pppery):
[phabricator/translations@wmf/stable] Add a bunch more locale files
Okay, that patch deals with the missing locale files. I fixed most of the remaining cases on translatewiki. Unfortunately there's one that needs to be fixed upstream, and then this will be as done as it can be (although there are parts of it that are neverending)
Change #1309266 merged by Aklapper:
[phabricator/translations@wmf/stable] Add a bunch more locale files
The following validation errors were found: The locale `ar` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `be_Tarask` defines a translation for the string "Belarusian (Belarus)", however that string does not appear to be referenced by the codebase. The locale `be_Tarask` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `br` defines a translation for the string "Belarusian (Belarus)", however that string does not appear to be referenced by the codebase. The locale `br` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `ce` defines a translation for the string "Belarusian (Belarus)", however that string does not appear to be referenced by the codebase. The locale `ce` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `fr_FR` defines a translation for the string "Belarusian (Belarus)", however that string does not appear to be referenced by the codebase. The locale `fr_FR` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `ja` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `ko_KR` defines a translation for the string "Belarusian (Belarus)", however that string does not appear to be referenced by the codebase. The locale `ko_KR` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `lb` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `nl` defines a translation for the string "Belarusian (Belarus)", however that string does not appear to be referenced by the codebase. The locale `nl` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `pl` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `pt_PT` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `ru` defines a translation for the string "Belarusian (Belarus)", however that string does not appear to be referenced by the codebase. The locale `ru` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `skr_Arab` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `sr_EC` defines a translation for the string "Belarusian (Belarus)", however that string does not appear to be referenced by the codebase. The locale `sr_EC` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `uk` defines a translation for the string "Belarusian (Belarus)", however that string does not appear to be referenced by the codebase. The locale `uk` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `zh_Hans` defines a translation for the string "Belarusian (Belarus)", however that string does not appear to be referenced by the codebase. The locale `zh_Hans` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `ps` defines a translation for the string "Belarusian (Belarus)", however that string does not appear to be referenced by the codebase. The locale `ps` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `vi` defines a translation for the string "Belarusian (Belarus)", however that string does not appear to be referenced by the codebase. The locale `vi` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `kg` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `kab` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `sk` defines a translation for the string "Belarusian (Belarus)", however that string does not appear to be referenced by the codebase. The locale `sk` defines a translation for the string "Norwegian", however that string does not appear to be referenced by the codebase. The locale `nl` defines a translation for the key `Maximum token name length is %d characters.`, which varies on the plurality or gender of parameter 1, however that parameter is not a number or person.
Still having more problems with the world shifting out from under me as source strings are added or removed. Hopefully the next set of patches will get it down to just the last entry (which is pending WMF pulling in next upstream, although I will probably close this as "close enough" when that's the only one left)
After next update
Translations are defined for the locale `kw`, which is not recognized. Translations are defined for the locale `ro`, which is not recognized. The locale `sk` defines a translation for the key `%d day(s)`, which varies on the plurality or gender of parameter 1, however that parameter is not a number or person. The locale `sk` defines a translation for the key `%d month(s)`, which varies on the plurality or gender of parameter 1, however that parameter is not a number or person. The locale `sk` defines a translation for the key `%d week(s)`, which varies on the plurality or gender of parameter 1, however that parameter is not a number or person. The locale `sk` defines a translation for the key `Dashboard names must not be longer than %s characters.`, which varies on the plurality or gender of parameter 1, however that parameter is not a number or person. The locale `nl` defines a translation for the key `Maximum token name length is %d characters.`, which varies on the plurality or gender of parameter 1, however that parameter is not a number or person. The locale `sk` defines a translation for the key `Panel names must not be longer than %s characters.`, which varies on the plurality or gender of parameter 1, however that parameter is not a number or person. The locale `sk` defines a translation for the key `Portal names must not be longer than %s characters.`, which varies on the plurality or gender of parameter 1, however that parameter is not a number or person.
Isn't chasing moving targets fun?
Change #1325535 had a related patch set uploaded (by Pppery; author: Pppery):
[phabricator/translations@wmf/stable] Add two new locale files
Okay, added the two missing locale files. The rest of these look like upstream problems.
pppery opened https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/126
Remove unused downstream-only function
Above patch deals with
The locale `sk` defines a translation for the key `%d day(s)`, which varies on the plurality or gender of parameter 1, however that parameter is not a number or person. The locale `sk` defines a translation for the key `%d month(s)`, which varies on the plurality or gender of parameter 1, however that parameter is not a number or person. The locale `sk` defines a translation for the key `%d week(s)`, which varies on the plurality or gender of parameter 1, however that parameter is not a number or person.
which aren't actually upstream. And once that is merged we'll need another update-and-generate cycle.
aklapper merged https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/126
Remove unused downstream-only function
Change #1325535 merged by Aklapper:
[phabricator/translations@wmf/stable] Add two new locale files