Page MenuHomePhabricator

[QA task] Revise Tone - user editing workflows limitations
Open, MediumPublic

Description

Follow up for T410167: QA Revise Tone Instrumentation & UX

Articles with Revise Tone task have non-trivial user workflow for switching between VE/source editing mode and Revise Tone surface

(1) Publishing non-revise tone edit is not possible

  • go to a Revise Tone article
  • without interacting with Revise tone suggestion (the highlighted section) or the revise Tone dialog- make an edit
  • the Publish button is active - click on it

What happened

  • the content of an article got dimmed and users cannot proceed with their edits without making decision on the Revise Tone section
Screenshot 2025-12-16 at 9.16.27 AM.png (732×1,584 px, 344 KB)
after clicking on publish button
Screenshot 2025-12-16 at 9.16.51 AM.png (734×1,502 px, 235 KB)

What should happen

  • a user should have a clear indication that normal edits are not possible at this point
  • a user should have guidance how to make normal edits from that state
  • a user should be able to opt-out from Revise tone task

DONE (re-checked on Jan 26/2026) (2) Clicking x button on mobile produces Uncaught TypeError: Cannot read properties of null (reading 'getSidebarDialogs')

  • on mobile go to a Revise tone article
  • without interacting with Revise tone suggestion (the highlighted section) or the revise Tone dialog - click on x button to exit the surface
  • the following Console error will be displayed:
 Uncaught TypeError: Cannot read properties of null (reading 'getSidebarDialogs')
at OO.EventEmitter.emit 
 at ve.ui.Surface.destroy
at ve.init.Target.clearSurfaces 
at ve.init.mw.MobileArticleTarget.clearSurfaces

Screenshot 2025-12-17 at 8.51.08 PM.png (946×1,576 px, 299 KB)

DONE (T414831: Revise Tone UI persists brokenly after closing and reopnening the editor) (3) The counter increases on each exiting & re-entering the Revise tone surface

  • go to a Revise Tone article
  • the highlighted section will display the warning icon (a yellow triangle) and no counter which is a correct behavior
  • without interacting with Revise tone suggestion (the highlighted section) or the revise Tone dialog - click on x button to exit the surface
  • on the same article click on the pencil button to start editing
  • Revise Tone surface is displayed and the counter appears

Screenshot 2025-12-17 at 9.12.58 PM.png (886×1,334 px, 181 KB)

  • at the bottom non-functional controls are displayed

Screenshot 2025-12-17 at 9.15.44 PM.png (698×1,462 px, 221 KB)

(4) "Before publishing" is displayed when a user tries to publish a normal edit - might be confusing for users what the next steps are:

  • from Homepage go to a Revise Tone article
  • without interacting with Revise Tone dialog, make a non-Revise Tone edits
  • the Publish icon is active - click on it
  • the surface is dimmed; the Revise Tone dialog is still displayed
  • "Before publishing" without any additional information is displayed

Screenshot 2025-12-22 at 10.38.59 AM.png (3,112×856 px, 375 KB)

DONE (per comment https://phabricator.wikimedia.org/T412832) (5) Tags Newcomer task Suggested: revise tone are added for non-Revise Tone edits
Ex. https://test.wikipedia.org/w/index.php?title=Lorem_ipsum&diff=704421&oldid=643573

Event Timeline

Etonkovidova updated Other Assignee, added: Michael.
Etonkovidova renamed this task from Revise Tone - switching to VE/source editors limitations to Revise Tone - user editing workflows limitations.Dec 22 2025, 4:02 PM
Etonkovidova updated the task description. (Show Details)
Etonkovidova renamed this task from Revise Tone - user editing workflows limitations to [QA task] Revise Tone - user editing workflows limitations.Jan 12 2026, 5:20 PM

(5) Tags Newcomer task Suggested: revise tone are added for non-Revise Tone edits
Ex. https://test.wikipedia.org/w/index.php?title=Lorem_ipsum&diff=704421&oldid=643573

@Etonkovidova this is by design. the edit tag tracks where the task was initiated (the newcomer homepage), even if the newcomer edits text beyond the highlighted tone issue. this is the same behavior as other suggested edits initiated from the newcomer homepage. it's important to preserve this because revise tone is the first semi-structured task that gives newcomers access to the full editor. we can mark point (5) of the description above as done if there are no further questions, thank you!