Page MenuHomePhabricator

Add total amount to Venmo paysheet
Closed, ResolvedPublic

Description

@greg reported the following on a Venmo testing thread:

Greg Grossmeier:
very quick/fluid.
Dumb question: after scanning the QR codes my Venmo app (Android) just asks me to confirm which bank account to pull from but doesn't list the amount that will be debited (it's on the original donatewiki page, of course). Pretty sure we have no control over that but just noting it.
(I guess that wasn't a question :slightly_smiling_face: )

After glancing at the Venmo docs, I found the following notice about the requirement to pass total_amount with transactions when using SDK v3.96.1 or greater and last week, we bumped our Venmo JS from v3.96.0 to v3.133.0, so this now applies:

image.png (649×1 px, 78 KB)

Let's pull the amount from the UI and send it pass it into the braintree.venmo.create() call.

Event Timeline

Change #1219580 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[mediawiki/extensions/DonationInterface@master] Pass total amount to Venmo payment request

https://gerrit.wikimedia.org/r/1219580

Change #1219580 abandoned by Jgleeson:

[mediawiki/extensions/DonationInterface@master] Pass total amount to Venmo payment request

Reason:

I'm gonna tackle this a different way

https://gerrit.wikimedia.org/r/1219580

Change #1219898 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[mediawiki/extensions/DonationInterface@master] Refactor braintree.js Venmo code.

https://gerrit.wikimedia.org/r/1219898

Change #1219908 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[mediawiki/extensions/DonationInterface@master] Refactor: Centralise Braintree client creation

https://gerrit.wikimedia.org/r/1219908

Change #1219931 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[mediawiki/extensions/DonationInterface@master] Venmo: create component on button click

https://gerrit.wikimedia.org/r/1219931

Change #1219932 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[mediawiki/extensions/DonationInterface@master] Refactor: extract out Venmo component creation

https://gerrit.wikimedia.org/r/1219932

Change #1219933 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[mediawiki/extensions/DonationInterface@master] Venmo: pass totalAmount at click time

https://gerrit.wikimedia.org/r/1219933

Change #1219934 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[mediawiki/extensions/DonationInterface@master] Refactor: reorder braintree.js helper functions

https://gerrit.wikimedia.org/r/1219934

Change #1219935 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[mediawiki/extensions/DonationInterface@master] Refactor: align PayPal client instance naming

https://gerrit.wikimedia.org/r/1219935

Change #1219898 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Refactor: tidy up braintree.js Venmo code.

https://gerrit.wikimedia.org/r/1219898

Change #1219908 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Refactor: centralise Braintree client creation

https://gerrit.wikimedia.org/r/1219908

Change #1219931 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Venmo: create component on button click

https://gerrit.wikimedia.org/r/1219931

Change #1219932 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Refactor: extract out Venmo component creation

https://gerrit.wikimedia.org/r/1219932

Change #1219933 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Venmo: pass totalAmount at click time

https://gerrit.wikimedia.org/r/1219933

Change #1219934 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Refactor: reorder braintree.js helper functions

https://gerrit.wikimedia.org/r/1219934

Change #1219935 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Refactor: align PayPal client instance naming

https://gerrit.wikimedia.org/r/1219935

XenoRyet set Final Story Points to 4.