Page MenuHomePhabricator
Create Task
Maniphest T41319

Don't allow re-tagging an article that already has that same tag
Open, LowPublic
Actions

Description

If two people are reviewing an article at the same time, they could both add BLP-PRODs. We should check and make sure the template isn't already present.

Version: master
Severity: minor

Details

Reference
bz39319
Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
toolbar: prevent duplicate tagsApehitkeymediawiki/extensions/PageTriagemaster+257 -3
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 12:47 AM
• bzimport added a project: PageTriage.
• bzimport set Reference to bz39319.
• bzimport added a subscriber: Unknown Object (MLST).
kaldari created this task.Aug 13 2012, 8:50 PM
Nischayn22 added a comment.Dec 31 2012, 3:12 AM

This happens in case of other templates as well..

Nischayn22 added a comment.Dec 31 2012, 3:17 AM

Related https://bugzilla.wikimedia.org/show_bug.cgi?id=39588

Quiddity added a project: Collaboration-Team-Triage.Oct 28 2015, 1:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 28 2015, 1:39 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 4 2018, 2:10 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 7:05 PM
Aklapper removed a project: Collaboration-Team-Triage.May 25 2021, 9:10 PM
MPGuy2824 merged a task: T130943: Page Curation doesn't check for existing tags.Oct 28 2022, 5:43 AM
MPGuy2824 added subscribers: QEDK, Catrope, • Mattflaschen-WMF.
Aklapper removed a project: PageTriage.Oct 17 2023, 9:07 PM
Aklapper edited projects, added: PageTriage; removed: Growth-Team.Oct 17 2023, 9:12 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 17 2023, 9:12 PM
Novem_Linguae moved this task from Backlog to Tagging wikicode bugs on the PageTriage board.Apr 6 2024, 12:04 AM
Novem_Linguae mentioned this in T353437: Maintenance tagging an article adds an unnecessary line break between top and template.Apr 6 2024, 12:11 AM
Pppery removed projects: Growth-Team, Growth-Team-Filtering.Jul 24 2024, 1:45 AM
Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptJul 24 2024, 1:45 AM
Samwalton9-WMF moved this task from Inbox to Triaged on the Moderator-Tools-Team board.Aug 13 2024, 11:55 AM
Monkeysmashingkeyboards claimed this task.Wed, Sep 9, 9:02 PM
Monkeysmashingkeyboards subscribed.

I'm going to claim all the wikicode tagging bugs since I recently "rewrote" (stole Novem's code) the toolbar tagging logic. I will hopefully be done with all of them in at most a week.

gerritbot added a comment.Thu, Sep 10, 3:38 AM

Change #1338460 had a related patch set uploaded (by Apehitkey; author: Apehitkey):

[mediawiki/extensions/PageTriage@master] toolbar: prevent duplicate tags

https://gerrit.wikimedia.org/r/1338460

gerritbot added a project: Patch-For-Review.Thu, Sep 10, 3:38 AM
Monkeysmashingkeyboards moved this task from Triaged to Code review requests on the Moderator-Tools-Team board.Fri, Sep 11, 3:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits