Page MenuHomePhabricator

External link check should not be shown within subsections of the excluded sections
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue:

What happens?:

image.png (1,375×574 px, 165 KB)

What should have happened instead?:
No check shown

Event Timeline

DLynch moved this task from Inbox to Ready to Be Worked On on the Editing-team (Kanban Board) board.
DLynch subscribed.

This is a little more complex than it sounds, because it involves making the exclude sections config significantly smarter -- currently it's 100% based on just "what's the previous heading?" and it needs to be expanded to keep going up the tree.

Change #1224082 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] BaseEditCheck: Consider whole heading hiearachy for excluded sections

https://gerrit.wikimedia.org/r/1224082

Change #1224082 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] BaseEditCheck: Consider whole heading hiearachy for excluded sections

https://gerrit.wikimedia.org/r/1224082

Ryasmeen edited projects, added: Verified; removed: Editing QA.