At the least, the earliest one in the document should be the one expanded.

I think the correct thing-to-do is to alter the current behavior so that the first run of check-generation in the initial document-load doesn't trigger the "a new check should be activated if there are no active checks" behavior. (But it should still happen later.)

Change #1223743 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/VisualEditor@master] EditCheck: load editor with all actions collapsed

https://gerrit.wikimedia.org/r/1223743

Change #1223747 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] EditCheck Controller: refresh returns a promise with the current actions

https://gerrit.wikimedia.org/r/1223747

Change #1223748 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/GrowthExperiments@master] ReviseTone: use new refresh behavior to ensure the check is focused

https://gerrit.wikimedia.org/r/1223748

Change #1223747 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] EditCheck Controller: refresh returns a promise with the current actions

https://gerrit.wikimedia.org/r/1223747

Change #1223748 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] ReviseTone: use new refresh behavior to ensure the check is focused

https://gerrit.wikimedia.org/r/1223748

Change #1223743 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] EditCheck: load editor with all actions collapsed

https://gerrit.wikimedia.org/r/1223743

A note for QA- for this, we decided on all cards being collapsed when the editor is first loaded. However, any new action (including tone check, whose behavior is a bit different) should still cause the card to expand.

In T413280#11509806, @medelius wrote:

However, any new action (including tone check, whose behavior is a bit different) should still cause the card to expand.

@medelius: could you please say a bit more about what "any new action" means in this context?

Also: where might be a good place for me to learn more about how we came to decide to make it so all cards are collapsed when the editor is first loaded?

what "any new action" means in this context?

Any check-action that appears after the editor has loaded. Tone check was called out because it's the only (current) check that doesn't get shown automatically because of where your selection is (because it only shows after your selection leaves the tone-violating paragraph).

Also: where might be a good place for me to learn more about how we came to decide to make it so all cards are collapsed when the editor is first loaded?

We talked about it a bit in the planning meeting last Monday, I think. I'm not sure which document wound up with notes for that (there are so many).

The basic logic was that the status quo wasn't acceptable, because it was selecting a slightly-random check-or-suggestion that wasn't even guaranteed to be the first one on the page, and "I scrolled down three page-lengths and found the seventh suggestion was expanded for no obvious reason" seems non-ideal. The alternative is to guarantee that the first check/suggestion in the document is expanded, and if we decide to do that then the nothing-expanded state is an easy base to build on for it. I do think it makes more sense for suggestions-in-particular to be unobtrusively waiting for you to decide to engage with them, though.

(Context for my phrasing: you can have a check on initial-load if you've wound up restoring an autosave.)

@DLynch: thank you for walking out this thinking.

So, in essence, it sounds like...?

1. Currently, the Check/Suggestion that was being expanded by default on-load was happening in an unpredictable way
2. In order for us to implement a point of view of what Suggestion(s)/Check(s) we want expanded when, we would benefit from first making it so all Checks/Suggestions are collapsed by default

Right! It gets us to a stable starting point.

Excellent.

(#TODO, once this task reaches Ready for sign off, create task for deciding how we want Checks/Suggestions to presented by default)

Change #1237265 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check: load editor on mobile without autofocusing takesFocus actions

https://gerrit.wikimedia.org/r/1237265

Change #1237265 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check: load editor on mobile without autofocusing takesFocus actions

https://gerrit.wikimedia.org/r/1237265