| Raymond | |
| Dec 22 2025, 11:47 AM |
| F71458198: Screenshot 2026-01-06 at 4.38.41 PM.png | |
| Jan 7 2026, 12:39 AM |
| F71197030: Screenshot 2025-12-22 123938.png | |
| Dec 22 2025, 11:47 AM |
| F71197026: Screenshot 2025-12-22 123855.png | |
| Dec 22 2025, 11:47 AM |
Steps to replicate the issue (include links if applicable):
What happens?:
What should have happened instead?:
No error should pop up
Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
This happens since the last deployment of the train to 1.46.0-wmf.7
I can reproduce this on my user sandbox page (though without the red popup – it just shows up in the console); &debug=2 shows the error comes from ve.ce.SelectionManager.prototype.updateDeactivatedSelection. I think that ce.SelectionManager: check for being destroyed in debounced methods, which IIUC made the selection nullable, seems like a likely “culprit”, so tagging @DLynch.
Ah, still a debounce issue, just methods being called on a timeout from outside of the manager.
Change #1220381 had a related patch set uploaded (by DLynch; author: DLynch):
[VisualEditor/VisualEditor@master] ce.SelectionManager: check for null surfaces
It's a production-error, but it's probably not worth an emergency backport -- it's from a setTimeout after a save has succeeded, a failed attempt to act on an already-destroyed editor surface, so it's basically log-spam that has no visible effect for a user who doesn't have debug tools turned on.
Change #1220381 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ce.SelectionManager: check for null surfaces
Change #1223291 had a related patch set uploaded (by DLynch; author: DLynch):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f53cf0905)
Change #1223291 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f53cf0905)
@DLynch could this be backported today? If you can't, I'm happy to help with that if you prepare the patches I need to backport.
Per https://wikitech.wikimedia.org/wiki/Deployments/Holding_the_train#Error-rate_increases_(See_#Logspam) this makes it harder to detect new issues during deploys.
Change #1223716 had a related patch set uploaded (by Jdlrobson; author: DLynch):
[mediawiki/extensions/VisualEditor@wmf/1.46.0-wmf.7] Update VE core submodule to master (f53cf0905)
Change #1223716 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.46.0-wmf.7] Update VE core submodule to master (f53cf0905)
Mentioned in SAL (#wikimedia-operations) [2026-01-06T22:13:18Z] <jdlrobson@deploy2002> Started scap sync-world: Backport for [[gerrit:1223715|Update VE core submodule to master (24389ad60)]], [[gerrit:rMW1223716aac25|Update VE core submodule to master (f53cf0905) (T413356)]]
Mentioned in SAL (#wikimedia-operations) [2026-01-06T22:15:44Z] <jdlrobson@deploy2002> jdlrobson: Backport for [[gerrit:1223715|Update VE core submodule to master (24389ad60)]], [[gerrit:rMW1223716aac25|Update VE core submodule to master (f53cf0905) (T413356)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.
Mentioned in SAL (#wikimedia-operations) [2026-01-06T22:23:35Z] <jdlrobson@deploy2002> Finished scap sync-world: Backport for [[gerrit:1223715|Update VE core submodule to master (24389ad60)]], [[gerrit:rMW1223716aac25|Update VE core submodule to master (f53cf0905) (T413356)]] (duration: 10m 17s)
I backported the change and looks like these are trailing off now!
https://logstash.wikimedia.org/goto/6655ae3638ac222b8b5c2f363147ead2
https://grafana.wikimedia.org/d/000000566/overview?orgId=1&from=now-12h&to=now&timezone=utc&viewPanel=panel-16
