Page MenuHomePhabricator
Create Task
Maniphest T413435

Special:ConfirmEmail does not resend a working email token
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

The verification email received:

image.png (544×1 px, 70 KB)

Clicking the link shows:

image.png (151×430 px, 15 KB)

What should have happened instead?:

Clicking the button should've confirmed the email address on the account.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
fix(ConfirmEmail): Save settings after generating tokensmediawiki/corewmf/1.46.0-wmf.7+7 -0
fix(ConfirmEmail): Save settings after generating tokensmediawiki/coremaster+7 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm_WMF created this task.Dec 23 2025, 2:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 23 2025, 2:06 PM
Urbanecm_WMF triaged this task as High priority.Dec 23 2025, 2:07 PM
Urbanecm_WMF added a subscriber: Michael.

Credits go to @Michael for discovering this bug.

Urbanecm_WMF claimed this task.Dec 23 2025, 2:08 PM
Urbanecm_WMF edited projects, added Growth-Team (FY2025-26 Q2 Sprint 6); removed Growth-Team.

This happened as a result of T396155: [Epic] Improve verification email (WE1.1.22 FY2025-26).

Urbanecm_WMF added a comment.Dec 23 2025, 2:10 PM

The problem happened in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1201717. Previously, User::sendConfirmationMail first generated the token, then persisted it via User::saveSettings() and then built the email. The new version misses User::saveSettings, resulting in this bug.

gerritbot added a comment.Dec 23 2025, 2:27 PM

Change #1220636 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] fix(ConfirmEmail): Save settings after generating tokens

https://gerrit.wikimedia.org/r/1220636

gerritbot added a project: Patch-For-Review.Dec 23 2025, 2:27 PM
Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (FY2025-26 Q2 Sprint 6) board.Dec 23 2025, 2:27 PM
Urbanecm_WMF added a parent task: T396155: [Epic] Improve verification email (WE1.1.22 FY2025-26).Dec 23 2025, 2:34 PM
gerritbot added a comment.Dec 23 2025, 2:57 PM

Change #1220636 merged by jenkins-bot:

[mediawiki/core@master] fix(ConfirmEmail): Save settings after generating tokens

https://gerrit.wikimedia.org/r/1220636

Ammarpad mentioned this in T413137: Our email confirmation workflow is incompatible with email providers that scan emails and follow links.Dec 23 2025, 3:06 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 23 2025, 3:30 PM
Xaosflux subscribed.Dec 24 2025, 3:34 PM

Is a current workaround to:

  1. Remove email address, save
  2. re-add email address, save

?

Urbanecm_WMF added a comment.Dec 24 2025, 3:38 PM

@Xaosflux Yes, that should be sufficient. An actual fix will be deployed early in 2026.

Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (FY2025-26 Q2 Sprint 6) board.Jan 7 2026, 1:00 PM
gerritbot added a comment.Jan 7 2026, 2:01 PM

Change #1224081 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@wmf/1.46.0-wmf.7] fix(ConfirmEmail): Save settings after generating tokens

https://gerrit.wikimedia.org/r/1224081

gerritbot added a project: Patch-For-Review.Jan 7 2026, 2:01 PM
gerritbot added a comment.Jan 7 2026, 2:13 PM

Change #1224081 merged by jenkins-bot:

[mediawiki/core@wmf/1.46.0-wmf.7] fix(ConfirmEmail): Save settings after generating tokens

https://gerrit.wikimedia.org/r/1224081

Stashbot added a comment.Jan 7 2026, 2:16 PM

Mentioned in SAL (#wikimedia-operations) [2026-01-07T14:16:24Z] <urbanecm@deploy2002> Started scap sync-world: Backport for [[gerrit:1224081|fix(ConfirmEmail): Save settings after generating tokens (T413435)]], [[gerrit:1210716|Stop setting $wgCampaignEventsEnableContributionTracking (T410939)]]

Stashbot mentioned this in T410939: Drop feature flag for collaborative contributions.Jan 7 2026, 2:16 PM
Stashbot added a comment.Jan 7 2026, 2:18 PM

Mentioned in SAL (#wikimedia-operations) [2026-01-07T14:18:29Z] <urbanecm@deploy2002> urbanecm, daimona: Backport for [[gerrit:1224081|fix(ConfirmEmail): Save settings after generating tokens (T413435)]], [[gerrit:1210716|Stop setting $wgCampaignEventsEnableContributionTracking (T410939)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Jan 7 2026, 2:24 PM

Mentioned in SAL (#wikimedia-operations) [2026-01-07T14:24:29Z] <urbanecm@deploy2002> Finished scap sync-world: Backport for [[gerrit:1224081|fix(ConfirmEmail): Save settings after generating tokens (T413435)]], [[gerrit:1210716|Stop setting $wgCampaignEventsEnableContributionTracking (T410939)]] (duration: 08m 05s)

Maintenance_bot removed a project: Patch-For-Review.Jan 7 2026, 2:31 PM
Urbanecm_WMF added a comment.Jan 7 2026, 2:56 PM

This was now backported to production.

Etonkovidova closed this task as Resolved.Jan 7 2026, 4:01 PM
Etonkovidova subscribed.

Checked on testwiki wmf.10 - the fix is in place.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits