Page MenuHomePhabricator
Create Task
Maniphest T413458

The search string should be automatically set as the selected text
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Enable CodeMirror 6 and open an edit page
  • Open the search panel, search something and then close the panel
  • Select some text, and open the search panel again

What happens?:

The search string is not automatically updated, which is different from CodeMirror's native search panel implementation.

What should have happened instead?:

The search string should be automatically updated.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Other Assignee
Bhsd
Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
CodeMirrorSearch: update search input with Mod-f/openPanelBhsdmediawiki/extensions/CodeMirrormaster+23 -7
CodeMirrorSearch: prefill Find input with selected textMusikAnimalmediawiki/extensions/CodeMirrormaster+5 -4
Customize query in gerrit

Event Timeline

Bhsd created this task.Dec 24 2025, 7:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 24 2025, 7:34 AM
Bhsd moved this task from Backlog to Improvement on the MediaWiki-extensions-CodeMirror board.Dec 24 2025, 7:35 AM
gerritbot added a comment.Dec 25 2025, 6:02 PM

Change #1221048 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] CodeMirrorSearch: prefill Find input with selected text

https://gerrit.wikimedia.org/r/1221048

gerritbot added a project: Patch-For-Review.Dec 25 2025, 6:02 PM
MusikAnimal changed the task status from Open to In Progress.Dec 25 2025, 6:02 PM
MusikAnimal claimed this task.
gerritbot added a comment.Dec 29 2025, 3:24 AM

Change #1221048 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirrorSearch: prefill Find input with selected text

https://gerrit.wikimedia.org/r/1221048

Maintenance_bot removed a project: Patch-For-Review.Dec 29 2025, 3:30 AM
Bhsd closed this task as Resolved.Jan 6 2026, 7:16 AM
Bhsd moved this task from Improvement to Done on the MediaWiki-extensions-CodeMirror board.
Nardog reopened this task as Open.EditedJan 9 2026, 10:06 AM
Nardog subscribed.

Ctrl+F/H should also update the input while the panel is open.

Bhsd added a comment.Jan 9 2026, 12:58 PM
In T413458#11506578, @Nardog wrote:

Ctrl+F/H should also update the input while the panel is open.

It feels strange to update the search input with Ctrl+H which places focus on the replace input.

gerritbot added a comment.Jan 9 2026, 1:40 PM

Change #1224955 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/CodeMirror@master] CodeMirrorSearch: update search input with Mod-f/openPanel

https://gerrit.wikimedia.org/r/1224955

gerritbot added a project: Patch-For-Review.Jan 9 2026, 1:40 PM
Nardog added a comment.Jan 10 2026, 1:37 PM

It feels strange to update the search input with Ctrl+H which places focus on the replace input.

I find it pretty handy. It allows you to quickly replace occurrences of the string you're selecting. Try it on Ace, VSCode, etc.

Bhsd moved this task from Done to Improvement on the MediaWiki-extensions-CodeMirror board.Jan 16 2026, 12:35 PM
gerritbot added a comment.Mar 3 2026, 6:04 AM

Change #1224955 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirrorSearch: update search input with Mod-f/openPanel

https://gerrit.wikimedia.org/r/1224955

Maintenance_bot removed a project: Patch-For-Review.Mar 3 2026, 6:30 AM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.19; 2026-03-10).Mar 3 2026, 7:00 AM
MusikAnimal closed this task as Resolved.Mar 26 2026, 9:54 PM
MusikAnimal moved this task from Improvement to Done on the MediaWiki-extensions-CodeMirror board.
MusikAnimal updated Other Assignee, added: Bhsd.

Ctrl+F/H should also update the input while the panel is open.

Sorry to keep asking you to do paperwork, but this too should be a separate task, I think. The bug that was reported has been fixed. What's being asked beyond that sounds like a feature request. Now, I know that I myself have not been particularly great at such task-splitting efforts for CodeMirror, hehe… but I'm trying to have us do better! This task for example already has two assignees. Ideally all tasks would have just one.

The other reason I'd prefer smaller tasks is to gauge interest. I have no reservations against Ctrl-H updating the replace input per se, but opinions may vary, and those opinions are unlikely to come when this specific request is buried in the comments instead of the task title.

Hopefully that makes sense! Thanks for your understanding :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits