tools/sync-parserTests.js expects to be run on master
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Dec 26 2025, 9:42 PM

Description

As seen on T413018: Parsoid tests in REL1_XX branches need updating for T407131, there is sometimes reason to run this on REL1_XX branches.

I note, in practice, the script seems to only git checkout master in case of error, and suggests console.log(' git rebase --keep-empty origin/master'); as a command to run...

But it should be possible to look at the currently checked out branch (or use the branch parameter to the script run?), and use that for the output.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Bump wikimedia/parsoid to 0.23.0-a12	mediawiki/vendor	master	+929 -492
Optionally pass a base to sync-parserTests.js	mediawiki/services/parsoid	REL1_45	+9 -7
Optionally pass a base to sync-parserTests.js	mediawiki/services/parsoid	REL1_43	+9 -7
Optionally pass a base to sync-parserTests.js	mediawiki/services/parsoid	REL1_44	+9 -7
Optionally pass a base to sync-parserTests.js	mediawiki/services/parsoid	master	+9 -7

Customize query in gerrit

Related Objects

Mentioned Here: T413018: Parsoid tests in REL1_XX branches need updating for T407131

Event Timeline

Reedy created this task.Dec 26 2025, 9:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 26 2025, 9:42 PM

Reedy updated the task description. (Show Details)Dec 26 2025, 9:43 PM

Reedy triaged this task as Low priority.Dec 26 2025, 9:51 PM

Hmm, I thought that I had done this already but it looks like we only ever merged the second half in https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/1022160

Change #1224184 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Optionally pass a base to sync-parserTests.js

https://gerrit.wikimedia.org/r/1224184

gerritbot added a project: Patch-For-Review.Jan 7 2026, 9:08 PM

ABreault-WMF claimed this task.Jan 7 2026, 9:09 PM

ABreault-WMF added a project: Content-Transform-Team (Work In Progress).

ABreault-WMF moved this task from Backlog to Code Review on the Content-Transform-Team (Work In Progress) board.Jan 8 2026, 1:29 AM

Change #1224184 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Optionally pass a base to sync-parserTests.js

https://gerrit.wikimedia.org/r/1224184

ABreault-WMF closed this task as Resolved.Jan 8 2026, 7:42 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 8 2026, 8:30 PM

Change #1224807 had a related patch set uploaded (by Reedy; author: Arlolra):

[mediawiki/services/parsoid@REL1_45] Optionally pass a base to sync-parserTests.js

https://gerrit.wikimedia.org/r/1224807

Change #1224808 had a related patch set uploaded (by Reedy; author: Arlolra):

[mediawiki/services/parsoid@REL1_44] Optionally pass a base to sync-parserTests.js

https://gerrit.wikimedia.org/r/1224808

Change #1224809 had a related patch set uploaded (by Reedy; author: Arlolra):

[mediawiki/services/parsoid@REL1_43] Optionally pass a base to sync-parserTests.js

https://gerrit.wikimedia.org/r/1224809

Change #1224808 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_44] Optionally pass a base to sync-parserTests.js

https://gerrit.wikimedia.org/r/1224808

Change #1224809 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_43] Optionally pass a base to sync-parserTests.js

https://gerrit.wikimedia.org/r/1224809

Change #1224807 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_45] Optionally pass a base to sync-parserTests.js

https://gerrit.wikimedia.org/r/1224807

Maintenance_bot removed a project: Patch-For-Review.Jan 8 2026, 9:30 PM

Change #1228553 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a12

https://gerrit.wikimedia.org/r/1228553

gerritbot added a project: Patch-For-Review.Jan 19 2026, 4:52 PM

Change #1228553 merged by jenkins-bot: