Page MenuHomePhabricator

Sortable table header markers are not shown in night mode if in namespace 100
Closed, InvalidPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • No sortable markers are shown

What should have happened instead?:

  • Sortable markers have to be shown

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

The cause is a night mode rule in particular the !important statement:

@media screen {
  .skin-theme-clientpref-night .ns-100 .mw-parser-output :not(.notheme):not(a) {
    background: inherit !important;
  }
}

Please add !important statements to the marker rules like:

html.skin-theme-clientpref-night.client-js .jquery-tablesorter th.headerSort {
  background-image: url(/w/resources/src/jquery.tablesorter.styles/images/sort_both_inverted.svg?d764d) !important;
  background-repeat: no-repeat !important;
  background-position: center right !important;
}

Event Timeline

The suggested fix, regardless of the issue, is not appropriate. Stacking importants on top of importants is not sustainable.

@Izno. You are true to reduce the usage of "important". But because it is already used it has to be used again for overwriting. Maybe the programmers of the night mode can change background to background-color only. I also do not know why such rules are necessary for this namespace only.

Escargot_rouge subscribed.

This is a temporary fix for night mode originating from the WikimediaMessages extension. As explained here, to disable it you need to create the page https://de.wikivoyage.org/wiki/MediaWiki:Wikimedia-styles-exclude and set its content to theme-night-portal.