logical:

$( textbox )
      .bind( 'keypress.srdialog', function ( e ) {
              if ( e.which == 13 ) {
                      // Enter
                      var button = dialog.data( 'dialogaction' ) || dialog.find( 'button:first' );
                      button.click();
                      e.preventDefault();
              } else if ( e.which == 27 ) {
                      // Escape
                      $(that).dialog( 'close' );
              }
      });

Now to solve it...

This is one idea:

https://gerrit.wikimedia.org/r/19942

probably better to this with exact match.

Change 19942 abandoned by TheDJ:
Enter in editbox should not submit Search dialog

https://gerrit.wikimedia.org/r/19942

Change abandoned after 11 months.

(In reply to comment #5)

Change abandoned after 11 months.

For which reason? No answer on your last commit in Gerrit and frustration, or are there actually technical reasons?

ehm, probably :)

@Vishwaak: No need to ask for permission. :) Anything we can help with?

The current situation (assuming a search term is found on the page):

• Pressing Enter on the search dialog finds the first search result.
• Focus is passed to the text area, with the search term selected.
• If you press Enter again (presumably to find the next search result), you're actually in the text area's context. The text area's handler tries to "click" a non-existent button, i.e. it does nothing.
• Pressing Esc does nothing. According to the jQuery docs, you need a keydown event, not keypress, to recognize Esc.

What do we want instead?

I actually feel the optimal behavior is a hybrid of the two:

• Enter should cycle through the search results.
• However, if the user explicitly selects the text area, it should input a new line.

Thoughts?