Please, revert this addition at line 239. That text is assigned to the constant FINAL_NEW_TEXT_ADDITIONS already.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| IMPR: Return the fully composed welcome text with get_welcome_text | Xqt | pywikibot/core | master | +96 -70 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Release | Xqt | T396368 Pywikibot 11 release | ||
| Resolved | Feature | Xqt | T414007 terminate welcome script gracefully if script is not localized | ||
| Resolved | BUG REPORT | Xqt | T413606 Restore previous welcome message for Italian Wikipedia |
Event Timeline
Comment Actions
I think it would be appropriate to remove the FINAL_NEW_TEXT_ADDITIONS mapping because it is not used by checkimages and there is no advantage over combining it with the template mapping.
Comment Actions
The advantage is that you can add some text at the very end of the welcome message. Date and time should be included inside the format string, if you want to handle the final text with a single mapping.
Comment Actions
Change #1222591 had a related patch set uploaded (by Xqt; author: Xqt):
[pywikibot/core@master] IMPR: Return the fully composed welcome text with get_welcome_text
Comment Actions
Change #1222591 merged by jenkins-bot:
[pywikibot/core@master] IMPR: Return the fully composed welcome text with get_welcome_text