Page MenuHomePhabricator
Create Task
Maniphest T41365

wfMakeUrlIndexes does not validate input
Closed, ResolvedPublic
Actions

Description

[15-Aug-2012 07:53:12] PHP Notice: Undefined index: scheme in /www/w/includes/GlobalFunctions.php on line 773
[15-Aug-2012 07:53:12] PHP Notice: Undefined index: host in /www/w/includes/GlobalFunctions.php on line 783
[15-Aug-2012 07:53:12] PHP Notice: Undefined index: scheme in /www/w/includes/GlobalFunctions.php on line 791
[15-Aug-2012 07:53:12] PHP Notice: Undefined index: delimiter in /www/w/includes/GlobalFunctions.php on line 792

Version: 1.20.x
Severity: normal

Details

Reference
bz39365

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:50 AM
• bzimport added a project: MediaWiki-General.
• bzimport set Reference to bz39365.
• bzimport added a subscriber: Unknown Object (MLST).
Nikerabbit created this task.Aug 15 2012, 8:19 AM
Krinkle added a project: Technical-Debt.Dec 10 2014, 2:08 PM
Krinkle set Security to None.
Krinkle removed a subscriber: Unknown Object (MLST).
MaxSem closed this task as Resolved.Mar 27 2019, 7:07 AM
MaxSem subscribed.

wfMakeUrlIndexes() is now LinkFilter::makeIndexes(), which, in combination with wfParseUrl(), handles errors properly. Nothing in logs and code review indicates that these warnings are now impossible.

• Phabricator_maintenance added a project: affects-translatewiki.net.Sep 26 2019, 1:53 PM
• Phabricator_maintenance removed a parent task: T41480: [DO NOT USE] Issues affecting translatewiki.net [superseded by #affects-translatewiki.net].Sep 26 2019, 1:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits