Page MenuHomePhabricator

wfMakeUrlIndexes does not validate input
Closed, ResolvedPublic

Description

[15-Aug-2012 07:53:12] PHP Notice: Undefined index: scheme in /www/w/includes/GlobalFunctions.php on line 773
[15-Aug-2012 07:53:12] PHP Notice: Undefined index: host in /www/w/includes/GlobalFunctions.php on line 783
[15-Aug-2012 07:53:12] PHP Notice: Undefined index: scheme in /www/w/includes/GlobalFunctions.php on line 791
[15-Aug-2012 07:53:12] PHP Notice: Undefined index: delimiter in /www/w/includes/GlobalFunctions.php on line 792


Version: 1.20.x
Severity: normal

Details

Reference
bz39365

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:50 AM
bzimport set Reference to bz39365.
bzimport added a subscriber: Unknown Object (MLST).
Krinkle set Security to None.
Krinkle removed a subscriber: Unknown Object (MLST).
MaxSem closed this task as Resolved.Mar 27 2019, 7:07 AM
MaxSem added a subscriber: MaxSem.

wfMakeUrlIndexes() is now LinkFilter::makeIndexes(), which, in combination with wfParseUrl(), handles errors properly. Nothing in logs and code review indicates that these warnings are now impossible.