Page MenuHomePhabricator

Ensure that evaluated implementations work with /v2/evaluate
Closed, ResolvedPublic

Description

Description

In particular, function arguments must be fully expanded!

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • evaluated function calls work with the abstractions in /src/transpilation

Completion checklist

Event Timeline

Jdforrester-WMF changed the task status from Open to In Progress.Jan 7 2026, 6:48 PM
Jdforrester-WMF triaged this task as Medium priority.

Change #1229569 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-01-07-163903 to 2026-01-21-135031

https://gerrit.wikimedia.org/r/1229569

Change #1229569 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-01-07-163903 to 2026-01-21-135031

https://gerrit.wikimedia.org/r/1229569

Jdforrester-WMF subscribed.

Deployed, but the tests don't work:

jforrester@deploy2002:/srv/deployment-charts/helmfile.d/services/wikifunctions$ curl https://wikifunctions.k8s-staging.discovery.wmnet:30443/1/v2/evaluate/ -X POST --data '{"zobject":{"Z1K1":"Z7","Z7K1":{"Z1K1":"Z8","Z8K1":["Z17",{"Z1K1":"Z17","Z17K1":"Z6","Z17K2":{"Z1K1":"Z6","Z6K1":"Z400K1"},"Z17K3":{"Z1K1":"Z12","Z12K1":["Z11"]}},{"Z1K1":"Z17","Z17K1":"Z6","Z17K2":{"Z1K1":"Z6","Z6K1":"Z400K2"},"Z17K3":{"Z1K1":"Z12","Z12K1":["Z11"]}}],"Z8K2":"Z1","Z8K3":["Z20"],"Z8K4":["Z14",{"Z1K1":"Z14","Z14K1":"Z400","Z14K3":{"Z1K1":"Z16","Z16K1":{"Z1K1":"Z61","Z61K1":"python"},"Z16K2": "def Z400(Z400K1,Z400K2):\n\treturn str(int(Z400K1) + int(Z400K2))"}}],"Z8K5":"Z400"},"Z400K1":"5","Z400K2":"8"},"doValidate":false}' --header "Content-type: application/json" -w "\n"
{"Z1K1":"Z22","Z22K1":"Z24","Z22K2":{"Z1K1":{"Z1K1":"Z7","Z7K1":"Z883","Z883K1":"Z6","Z883K2":"Z1"},"K1":[{"Z1K1":"Z7","Z7K1":"Z882","Z882K1":"Z6","Z882K2":"Z1"},{"Z1K1":{"Z1K1":"Z7","Z7K1":"Z882","Z882K1":"Z6","Z882K2":"Z1"},"K1":"errors","K2":{"Z1K1":"Z5","Z5K1":"Z558","Z5K2":"Orchestration generally failed."}}]}}

Change #1234428 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-01-21-135031 to 2026-01-28-071101

https://gerrit.wikimedia.org/r/1234428

Change #1234428 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-01-21-135031 to 2026-01-28-071101

https://gerrit.wikimedia.org/r/1234428