Page MenuHomePhabricator

Nominating a redirect at RfD using Page Curation leaves an edit to the RfD daily log page without an edit summary
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Nominate a redirect named "Foo" at RfD using Page Curation

What happens?: The edit adding the RfD nomination to the daily log page has no edit summary.

What should have happened instead?: The edit adding the RfD nomination to the daily log page has an edit summary that says Adding [[Foo]].

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

See https://en.wikipedia.org/w/index.php?title=Wikipedia%3ARedirects+for+discussion%2FLog%2F2026+January+5&date-range-to=&tagfilter=pagetriage&action=history for example.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1225658 had a related patch set uploaded (by SarthakSingh2904; author: SarthakSingh2904):

[mediawiki/extensions/PageTriage@master] Add edit summary for RfD nominations via PageTriage

https://gerrit.wikimedia.org/r/1225658

Change #1225658 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Add edit summary for RfD nominations via PageTriage

https://gerrit.wikimedia.org/r/1225658

While I don't disagree with the direction, I'm a bit confused about the current patch being merged in its current :( Shouldn't we be i18n-ing that string ?

While I don't disagree with the direction, I'm a bit confused about the current patch being merged in its current :( Shouldn't we be i18n-ing that string ?

Most of the strings here are not i18n (see line 56 of the same file). We can create a new ticket to address all of the strings that need to be converted to i18n and follow-up.