Summary
We need to add a default value for the *_agent columns (i.e. cuc_agent, cule_agent, cupe_agent) so that we can stop writing to these columns in T361205
Proposed schema changes
Add a default value of an empty string to cuc_agent, cule_agent, and cupe_agent in their respective tables:
describe cu_changes; +----------------+---------------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +----------------+---------------------+------+-----+---------+----------------+ ... | cuc_agent | varbinary(255) | YES | | | | | cuc_agent_id | bigint(20) unsigned | NO | | 0 | | +----------------+---------------------+------+-----+---------+----------------+
describe cu_log_event; +----------------+---------------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +----------------+---------------------+------+-----+---------+----------------+ ... | cule_agent | varbinary(255) | YES | | | | | cule_agent_id | bigint(20) unsigned | NO | | 0 | | +----------------+---------------------+------+-----+---------+----------------+
describe cu_private_event; +----------------+---------------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +----------------+---------------------+------+-----+---------+----------------+ ... | cupe_agent | varbinary(255) | YES | | | | | cupe_agent_id | bigint(20) unsigned | NO | | 0 | | +----------------+---------------------+------+-----+---------+----------------+
Acceptance criteria
- The schema change is merged in the master branch of the CheckUser extension
- Code is added to the CheckUserInsert service to support not writing to these columns
- A Schema-change-in-production ticket is filed to apply the change on WMF wikis