Page MenuHomePhabricator

Disconnected tests on built-in functions reduce clarity of expected behaviour
Open, MediumPublic

Description

Description

Based on community feedback, tests for built-in functions are often left disconnected because only Maintainers (currently staff only) can connect or disconnect them. Community members report that requests to connect such tests have been made but were not followed up on, leading to tests remaining disconnected.
Since built-in function code is not visible, connected tests are a way to check the expected behaviour of a built-in function.

Community feedback - Date: 11 Dec 2025

The tests of first element / Z811(and some other built-in functions) are "disconnected because they have never been connected (similar to almost all built-ins). That is because the community do not yet have the functionmaintainer right ([[Wikifunctions:Maintainers]]), and because staff have been too busy or found it hard every time connections have been requested. I won't speak for Nizo, but the reason I want good tests connected on all built-in functions is to demonstrate the expected behaviour of the function, especially given that we can't see the code. For example, by leaving Z24838 disconnected, we suggest that this is not expected/desired behaviour for this function (but why not??). If it is desired, then just like any other function, I would suggest connecting it, and admitting that our current (built-in) implementation is not quite doing everything we hope it will do."

Potential Approaches (for discussion)

  • Clarify process: understand how/where the community has been requesting test connections, identify breakdowns, and improve the process.
  • Consider permission changes: consider allowing functioneers to connect/disconnect tests to/from built-in functions

Completion checklist

Event Timeline

Jdforrester-WMF subscribed.

Moving the scary rights away from Maintainer to the more common (and available!) Functioneer status is a big change, and should go through a proper product/community lead discussion before we think about doing this!

LMorgantini-WMF renamed this task from Rights: consider allowing functioneers to connect/disconnect tests to/from built-in functions to Disconnected tests on built-in functions reduce clarity of expected behaviour.Jan 13 2026, 12:51 AM
LMorgantini-WMF updated the task description. (Show Details)

So far community has requested connections through direct messages to members of the staff, who were happy to comply. There is a list of unconnected tests that is lying around somewhere in community pages, that hasn't received attention in a while. It is not considered a top-of-the-list problem by the community, but a working policy on this might be good to have. One hypothesis can be attributing the privilege to function maintainers, a role that we didn't release yet.

Let's re-visit as usage of Wikifunctions increases.