Page MenuHomePhabricator

Add CS IDs to list of CS SMW Properties
Closed, ResolvedPublic

Description

Feature Request - Comment Streams require all <comment-streams> tags to include an "ID" that is (presumably) unique to the page. Among other things, this allow users to add multiple comment streams to a single page.. It would be really great if this unique ID was quarriable by SMW. Currently, I can search for comments by page name of the page they are hosted on and by comment title. I use SMW to add comment streams to pages via a result temple and being able to query the CS ID elsewhere would be super helpful. Thanks!
/Rich

Event Timeline

Change #1228263 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/CommentStreams@master] Add comment stream block ID as an SMW property on a comment

https://gerrit.wikimedia.org/r/1228263

Change #1228263 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@master] Add comment stream block ID/text as SMW properties on a comment

https://gerrit.wikimedia.org/r/1228263

Change #1232806 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/CommentStreams@REL1_43] Add comment stream block ID/text as SMW properties on a comment

https://gerrit.wikimedia.org/r/1232806

Change #1232807 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/CommentStreams@REL1_44] Add comment stream block ID/text as SMW properties on a comment

https://gerrit.wikimedia.org/r/1232807

Change #1232808 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/CommentStreams@REL1_45] Add comment stream block ID/text as SMW properties on a comment

https://gerrit.wikimedia.org/r/1232808

Change #1232806 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@REL1_43] Add comment stream block ID/text as SMW properties on a comment

https://gerrit.wikimedia.org/r/1232806

Change #1232807 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@REL1_44] Add comment stream block ID/text as SMW properties on a comment

https://gerrit.wikimedia.org/r/1232807

Change #1232808 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@REL1_45] Add comment stream block ID/text as SMW properties on a comment

https://gerrit.wikimedia.org/r/1232808

I just tested git fetch https://gerrit.wikimedia.org/r/mediawiki/extensions/CommentStreams refs/changes/93/1233393/9 && git checkout -b change-1233393 FETCH_HEAD

and confirmed that this issue has been implemented and can be closed. (Is there something more I can or should do on this issue?)

cicalese claimed this task.
cicalese subscribed.

In the future, you can change the status to Resolved once you have confirmed that it works. But, I will do that now.