Summary

Background

• T361192: Read user agent strings from the cu_useragent table in Special:CheckUser, T361193: Read user agent strings from the cu_useragent table in the CheckUser API, and T361195: Read user agent strings from the cu_useragent table in Special:Investigate have updated the main interfaces where the User Agent column is read from the CheckUser result tables.
  • This task is to encompass all other interfaces that need updating to read from the new agent_id column when the migration is set to read new
• The interfaces known about so far are:
  • The AccountCreationDetailsLookup service from CheckUser
  • data-engineering repos which is handled by T361210: Changes to the cuc_agent column in the cu_changes table
  • AccountInfo is handled by T366719: Update AccountInfo InfoLookup::getUserInfo to read data from cu_log_event and cu_private_event, and is not WMF deployed so we can largely ignore that repo
  • edwardspec/mediawiki-moderation which is not deployed to WMF wikis and follows the release cycle, so we can probably ignore for now
• Other places needing an update can be found through https://codesearch.wmcloud.org/search/?q=cuc_agent%7Ccule_agent%7Ccupe_agent&files=&excludeFiles=&repos= (though some like the AbuseFilter example are fine to leave as the CheckUserInsert service would handle making *_agent into *_agent_id)

Acceptance criteria

• All code in CheckUser uses the agent_id column instead of the agent column when reading new
• All code outside CheckUser that directly reads from the DB is checked and updated if necessary