Page MenuHomePhabricator
Create Task
Maniphest T413901

imagedestroy() is deprecated since PHP 8.5, as it has no effect since PHP 8.0
Open, In Progress, MediumPublic
Actions

Description

https://www.php.net/manual/en/migration85.deprecated.php#migration85.deprecated.gd:

The imagedestroy() function has been deprecated, as GdImage objects are freed automatically.

https://www.php.net/manual/en/function.imagedestroy.php:

This function has no effect. Prior to PHP 8.0.0, this function was used to close the resource.

https://codesearch.wmcloud.org/search/?q=imagedestroy (false positives removed):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
specials: Remove calls to `imagedestroy()`mediawiki/extensions/SportsTeamsmaster+0 -8
BsFileSystemHelper: Remove call to `imagedestroy()`mediawiki/extensions/BlueSpiceFoundationmaster+0 -1
EImageIMG: Wrap calls to `imagedestroy()` in a check for PHP < 8.0mediawiki/extensions/EImagemaster+9 -3
Remove calls to `imagedestroy()`mediawiki/extensions/SocialProfilemaster+0 -12
Media: Remove deprecated imagedestroymediawiki/coreREL1_44+1 -6
Media: Remove deprecated imagedestroymediawiki/coreREL1_45+1 -6
Media: Remove deprecated imagedestroymediawiki/coremaster+1 -6
Media: Remove deprecated imagedestroymediawiki/coreREL1_43+1 -6
Remove deprecated imagedestroy() callmediawiki/extensions/FileImportermaster+0 -1
Customize query in gerrit

Related Objects

Event Timeline

A_smart_kitten created this task.Jan 6 2026, 5:08 PM
A_smart_kitten claimed this task.
A_smart_kitten triaged this task as Medium priority.

Planning to file patches

A_smart_kitten added a project: ci-test-error.Jan 6 2026, 6:33 PM

This causes test failures on PHP 8.5 for mediawiki/core & mediawiki/extensions/FileImporter - pasting the failures below for searchability. (I haven't checked for the other repos.)

mediawiki/core
$ composer phpunit:entrypoint -- --filter ExifRotationTest
[...]
1) ExifRotationTest::testRotationRendering with data set #0 ('landscape-plain.jpg', 'image/jpeg', array(160, 120), array(array(80, 60), array(107, 80), array(80, 60), array(60, 45)))
Function imagedestroy() is deprecated since 8.5, as it has no effect since PHP 8.0

/[...]/includes/Media/BitmapHandler.php:504
/[...]/includes/Media/TransformationalImageHandler.php:252
/[...]/includes/FileRepo/File/File.php:1406
/[...]/includes/FileRepo/File/File.php:1351
/[...]/tests/phpunit/includes/Media/ExifRotationTest.php:92
=== Logs generated by test case
[...]
===

2) ExifRotationTest::testRotationRendering with data set #1 ('portrait-rotated.jpg', 'image/jpeg', array(120, 160), array(array(45, 60), array(60, 80), array(80, 107), array(60, 80)))
Function imagedestroy() is deprecated since 8.5, as it has no effect since PHP 8.0

/[...]/includes/Media/BitmapHandler.php:491
/[...]/includes/Media/TransformationalImageHandler.php:252
/[...]/includes/FileRepo/File/File.php:1406
/[...]/includes/FileRepo/File/File.php:1351
/[...]/tests/phpunit/includes/Media/ExifRotationTest.php:92
=== Logs generated by test case
[...]
===

3) ExifRotationTest::testRotationRenderingNoAutoRotate with data set #0 ('landscape-plain.jpg', 'image/jpeg', array(160, 120), array(array(80, 60), array(107, 80), array(80, 60), array(60, 45)))
Function imagedestroy() is deprecated since 8.5, as it has no effect since PHP 8.0

/[...]/includes/Media/BitmapHandler.php:504
/[...]/includes/Media/TransformationalImageHandler.php:252
/[...]/includes/FileRepo/File/File.php:1406
/[...]/includes/FileRepo/File/File.php:1351
/[...]/tests/phpunit/includes/Media/ExifRotationTest.php:198
=== Logs generated by test case
[...]
===

4) ExifRotationTest::testRotationRenderingNoAutoRotate with data set #1 ('portrait-rotated.jpg', 'image/jpeg', array(160, 120), array(array(80, 60), array(107, 80), array(80, 60), array(60, 45)))
Function imagedestroy() is deprecated since 8.5, as it has no effect since PHP 8.0

/[...]/includes/Media/BitmapHandler.php:504
/[...]/includes/Media/TransformationalImageHandler.php:252
/[...]/includes/FileRepo/File/File.php:1406
/[...]/includes/FileRepo/File/File.php:1351
/[...]/tests/phpunit/includes/Media/ExifRotationTest.php:198
=== Logs generated by test case
[...]
===
mediawiki/extensions/FileImporter
$ composer phpunit:entrypoint -- extensions/FileImporter/ --filter FileImporterUploadBaseTest
[...]
1) FileImporter\Tests\MediaWiki\FileImporterUploadBaseTest::testPerformFileChecks with data set "validPNG" ('Foo.png', 'png')
Function imagedestroy() is deprecated since 8.5, as it has no effect since PHP 8.0

/[...]/extensions/FileImporter/tests/phpunit/MediaWiki/FileImporterUploadBaseTest.php:82
/[...]/extensions/FileImporter/tests/phpunit/MediaWiki/FileImporterUploadBaseTest.php:59
=== Logs generated by test case
[...]
===

2) FileImporter\Tests\MediaWiki\FileImporterUploadBaseTest::testPerformFileChecks with data set "validGIF" ('Foo.gif', 'gif')
Function imagedestroy() is deprecated since 8.5, as it has no effect since PHP 8.0

/[...]/extensions/FileImporter/tests/phpunit/MediaWiki/FileImporterUploadBaseTest.php:82
/[...]/extensions/FileImporter/tests/phpunit/MediaWiki/FileImporterUploadBaseTest.php:59
=== Logs generated by test case
[...]
===

3) FileImporter\Tests\MediaWiki\FileImporterUploadBaseTest::testPerformFileChecks with data set "validJPEG" ('Foo.jpeg', 'jpeg')
Function imagedestroy() is deprecated since 8.5, as it has no effect since PHP 8.0

/[...]/extensions/FileImporter/tests/phpunit/MediaWiki/FileImporterUploadBaseTest.php:82
/[...]/extensions/FileImporter/tests/phpunit/MediaWiki/FileImporterUploadBaseTest.php:59
=== Logs generated by test case
[...]
===

4) FileImporter\Tests\MediaWiki\FileImporterUploadBaseTest::testPerformFileChecks with data set "PNGwithBadExtension" ('Foo.jpeg', 'png', 'filetype-mime-mismatch')
Function imagedestroy() is deprecated since 8.5, as it has no effect since PHP 8.0

/[...]/extensions/FileImporter/tests/phpunit/MediaWiki/FileImporterUploadBaseTest.php:82
/[...]/extensions/FileImporter/tests/phpunit/MediaWiki/FileImporterUploadBaseTest.php:59
=== Logs generated by test case
[...]
===

5) FileImporter\Tests\MediaWiki\FileImporterUploadBaseTest::testPerformFileChecks with data set "GIFwithBadExtension" ('Foo.jpeg', 'gif', 'filetype-mime-mismatch')
Function imagedestroy() is deprecated since 8.5, as it has no effect since PHP 8.0

/[...]/extensions/FileImporter/tests/phpunit/MediaWiki/FileImporterUploadBaseTest.php:82
/[...]/extensions/FileImporter/tests/phpunit/MediaWiki/FileImporterUploadBaseTest.php:59
=== Logs generated by test case
[...]
===

6) FileImporter\Tests\MediaWiki\FileImporterUploadBaseTest::testPerformFileChecks with data set "JPEGwithBadExtension" ('Foo.gif', 'jpeg', 'filetype-mime-mismatch')
Function imagedestroy() is deprecated since 8.5, as it has no effect since PHP 8.0

/[...]/extensions/FileImporter/tests/phpunit/MediaWiki/FileImporterUploadBaseTest.php:82
/[...]/extensions/FileImporter/tests/phpunit/MediaWiki/FileImporterUploadBaseTest.php:59
=== Logs generated by test case
[...]
===
gerritbot added a comment.Jan 9 2026, 2:18 PM

Change #1224960 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FileImporter@master] Remove deprecated imagedestroy() call

https://gerrit.wikimedia.org/r/1224960

gerritbot added a project: Patch-For-Review.Jan 9 2026, 2:18 PM
gerritbot added a comment.Jan 9 2026, 2:44 PM

Change #1224960 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Remove deprecated imagedestroy() call

https://gerrit.wikimedia.org/r/1224960

Maintenance_bot removed a project: Patch-For-Review.Jan 9 2026, 3:31 PM
thiemowmde removed a project: Move-Files-To-Commons.Jan 12 2026, 10:25 AM
thiemowmde updated the task description. (Show Details)
A_smart_kitten mentioned this in T411814: Make PHP 8.5 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI.Jan 12 2026, 11:11 AM
A_smart_kitten changed the task status from Open to In Progress.Jan 14 2026, 3:55 PM
A_smart_kitten updated the task description. (Show Details)
A_smart_kitten updated the task description. (Show Details)Jan 14 2026, 4:39 PM
Umherirrender mentioned this in T414875: Update JamesHeinrich/getID3 for php8.5 support.Jan 18 2026, 1:11 AM
A_smart_kitten mentioned this in T227704: Codesearch: "mediawiki/vendor" is missing from Everything preset.Jan 18 2026, 6:56 PM
A_smart_kitten updated the task description. (Show Details)Wed, Jan 21, 1:28 PM
gerritbot added a comment.Wed, Jan 21, 8:13 PM

Change #1229675 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Media: Remove deprecated imagedestroy

https://gerrit.wikimedia.org/r/1229675

gerritbot added a project: Patch-For-Review.Wed, Jan 21, 8:13 PM
gerritbot added a comment.Wed, Jan 21, 8:59 PM

Change #1229675 merged by jenkins-bot:

[mediawiki/core@master] Media: Remove deprecated imagedestroy

https://gerrit.wikimedia.org/r/1229675

gerritbot added a comment.Wed, Jan 21, 9:07 PM

Change #1229691 had a related patch set uploaded (by Zabe; author: Umherirrender):

[mediawiki/core@REL1_43] Media: Remove deprecated imagedestroy

https://gerrit.wikimedia.org/r/1229691

gerritbot added a comment.Wed, Jan 21, 9:08 PM

Change #1229692 had a related patch set uploaded (by Zabe; author: Umherirrender):

[mediawiki/core@REL1_44] Media: Remove deprecated imagedestroy

https://gerrit.wikimedia.org/r/1229692

gerritbot added a comment.Wed, Jan 21, 9:08 PM

Change #1229693 had a related patch set uploaded (by Zabe; author: Umherirrender):

[mediawiki/core@REL1_45] Media: Remove deprecated imagedestroy

https://gerrit.wikimedia.org/r/1229693

gerritbot added a comment.Wed, Jan 21, 9:51 PM

Change #1229691 merged by jenkins-bot:

[mediawiki/core@REL1_43] Media: Remove deprecated imagedestroy

https://gerrit.wikimedia.org/r/1229691

gerritbot added a comment.Wed, Jan 21, 9:53 PM

Change #1229693 merged by jenkins-bot:

[mediawiki/core@REL1_45] Media: Remove deprecated imagedestroy

https://gerrit.wikimedia.org/r/1229693

gerritbot added a comment.Wed, Jan 21, 9:56 PM

Change #1229692 merged by jenkins-bot:

[mediawiki/core@REL1_44] Media: Remove deprecated imagedestroy

https://gerrit.wikimedia.org/r/1229692

Maintenance_bot removed a project: Patch-For-Review.Wed, Jan 21, 10:31 PM
A_smart_kitten added a project: MediaWiki-Vendor.Thu, Jan 22, 11:50 AM
A_smart_kitten updated the task description. (Show Details)
gerritbot added a comment.Thu, Jan 22, 12:51 PM

Change #1230319 had a related patch set uploaded (by A smart kitten; author: A smart kitten):

[mediawiki/extensions/BlueSpiceFoundation@master] BsFileSystemHelper: Remove call to `imagedestroy()`

https://gerrit.wikimedia.org/r/1230319

gerritbot added a project: Patch-For-Review.Thu, Jan 22, 12:51 PM
gerritbot added a comment.Thu, Jan 22, 1:00 PM

Change #1230322 had a related patch set uploaded (by A smart kitten; author: A smart kitten):

[mediawiki/extensions/SportsTeams@master] specials: Remove calls to `imagedestroy()`

https://gerrit.wikimedia.org/r/1230322

gerritbot added a comment.Thu, Jan 22, 1:08 PM

Change #1230324 had a related patch set uploaded (by A smart kitten; author: A smart kitten):

[mediawiki/extensions/SocialProfile@master] Remove calls to `imagedestroy()`

https://gerrit.wikimedia.org/r/1230324

gerritbot added a comment.Thu, Jan 22, 1:46 PM

Change #1230337 had a related patch set uploaded (by A smart kitten; author: A smart kitten):

[mediawiki/extensions/EImage@master] EImageIMG: Wrap calls to `imagedestroy()` in a check for PHP < 8.0

https://gerrit.wikimedia.org/r/1230337

A_smart_kitten updated the task description. (Show Details)Thu, Jan 22, 2:18 PM
A_smart_kitten added a project: User-a_smart_kitten.Fri, Jan 23, 1:13 PM
gerritbot added a comment.Mon, Jan 26, 1:13 PM

Change #1230324 merged by jenkins-bot:

[mediawiki/extensions/SocialProfile@master] Remove calls to `imagedestroy()`

https://gerrit.wikimedia.org/r/1230324

gerritbot added a comment.Mon, Jan 26, 4:09 PM

Change #1230337 merged by jenkins-bot:

[mediawiki/extensions/EImage@master] EImageIMG: Wrap calls to `imagedestroy()` in a check for PHP < 8.0

https://gerrit.wikimedia.org/r/1230337

A_smart_kitten updated the task description. (Show Details)Mon, Jan 26, 4:22 PM
jenkins-bot mentioned this in rEEIM2596fd5bb6a3: EImageIMG: Wrap calls to `imagedestroy()` in a check for PHP < 8.0.Mon, Jan 26, 4:23 PM
Krinkle removed a project: ci-test-error.Mon, Feb 16, 4:18 PM
gerritbot added a comment.Tue, Feb 17, 8:13 PM

Change #1230322 merged by Umherirrender:

[mediawiki/extensions/SportsTeams@master] specials: Remove calls to `imagedestroy()`

https://gerrit.wikimedia.org/r/1230322

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits