Using null as an array offset is deprecated, use an empty string instead (from Page/LinkBatch.php:322)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	A_smart_kitten
	Jan 6 2026, 8:50 PM

Project Tags

Referenced Files

None

Subscribers

A_smart_kitten

Aklapper

Description

mediawiki/core locally running PHP 8.5
composer phpunit:entrypoint -- --filter LinkBatchTest

1) LinkBatchTest::testAddObj
Using null as an array offset is deprecated, use an empty string instead

/[...]/mediawiki/core/includes/Page/LinkBatch.php:322
/[...]/mediawiki/core/includes/Page/LinkBatch.php:263
/[...]/mediawiki/core/includes/Page/LinkBatch.php:229
/[...]/mediawiki/core/includes/Page/LinkBatch.php:241
/[...]/mediawiki/core/tests/phpunit/includes/Page/LinkBatchTest.php:94

2) LinkBatchTest::testAdd
Using null as an array offset is deprecated, use an empty string instead

/[...]/mediawiki/core/includes/Page/LinkBatch.php:322
/[...]/mediawiki/core/includes/Page/LinkBatch.php:263
/[...]/mediawiki/core/includes/Page/LinkBatch.php:229
/[...]/mediawiki/core/includes/Page/LinkBatch.php:241
/[...]/mediawiki/core/tests/phpunit/includes/Page/LinkBatchTest.php:108

3) LinkBatchTest::testAddBadObj with data set "bad user" (MediaWiki\Title\Title Object (...))
Using null as an array offset is deprecated, use an empty string instead

/[...]/mediawiki/core/includes/Page/LinkBatch.php:322
/[...]/mediawiki/core/includes/Page/LinkBatch.php:263
/[...]/mediawiki/core/includes/Page/LinkBatch.php:229
/[...]/mediawiki/core/tests/phpunit/includes/Page/LinkBatchTest.php:260

4) LinkBatchTest::testAddBadDBKeys with data set "section" ('#See_also')
Using null as an array offset is deprecated, use an empty string instead

/[...]/mediawiki/core/includes/Page/LinkBatch.php:322
/[...]/mediawiki/core/includes/Page/LinkBatch.php:263
/[...]/mediawiki/core/includes/Page/LinkBatch.php:229
/[...]/mediawiki/core/tests/phpunit/includes/Page/LinkBatchTest.php:276

5) LinkBatchTest::testAddBadDBKeys with data set "pipe" ('foo|bar')
Using null as an array offset is deprecated, use an empty string instead

/[...]/mediawiki/core/includes/Page/LinkBatch.php:322
/[...]/mediawiki/core/includes/Page/LinkBatch.php:263
/[...]/mediawiki/core/includes/Page/LinkBatch.php:229
/[...]/mediawiki/core/tests/phpunit/includes/Page/LinkBatchTest.php:276

(note: not yet seen in WMF experimental CI due to the order in which it runs MediaWiki's PHPUnit tests, but it presumably would be seen there at some point)

Details

Related Changes in Gerrit:

Subject	Author	Repo	Branch	Lines +/-
tests: Use real TitleFormatter in LinkBatchTest	Umherirrender	mediawiki/core	REL1_43	+1 -1
tests: Use real TitleFormatter in LinkBatchTest	Umherirrender	mediawiki/core	REL1_44	+1 -1
tests: Use real TitleFormatter in LinkBatchTest	Umherirrender	mediawiki/core	REL1_45	+1 -1
tests: Use real TitleFormatter in LinkBatchTest	Umherirrender	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T410514 Using null as array offset or as the key parameter for array_key_exists() is deprecated in PHP 8.5
		Resolved		Umherirrender	T413919 Using null as an array offset is deprecated, use an empty string instead (from Page/LinkBatch.php:322)

Event Timeline

A_smart_kitten created this task.Jan 6 2026, 8:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2026, 8:50 PM

Reedy moved this task from Backlog to MediaWiki core on the PHP 8.5 support board.Jan 6 2026, 9:36 PM

A_smart_kitten mentioned this in T411814: Make PHP 8.5 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI.Jan 12 2026, 11:11 AM

Umherirrender claimed this task.Jan 18 2026, 8:09 PM

Change #1228292 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Use real TitleFormatter in LinkBatchTest

https://gerrit.wikimedia.org/r/1228292

gerritbot added a project: Patch-For-Review.Jan 18 2026, 8:09 PM

Change #1228292 merged by jenkins-bot:

[mediawiki/core@master] tests: Use real TitleFormatter in LinkBatchTest

https://gerrit.wikimedia.org/r/1228292

Maintenance_bot removed a project: Patch-For-Review.Jan 19 2026, 9:31 AM

Change #1228579 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_45] tests: Use real TitleFormatter in LinkBatchTest

https://gerrit.wikimedia.org/r/1228579

gerritbot added a project: Patch-For-Review.Jan 19 2026, 7:18 PM

Change #1228585 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_44] tests: Use real TitleFormatter in LinkBatchTest

https://gerrit.wikimedia.org/r/1228585

Change #1228589 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_43] tests: Use real TitleFormatter in LinkBatchTest

https://gerrit.wikimedia.org/r/1228589

Change #1228579 merged by jenkins-bot:

[mediawiki/core@REL1_45] tests: Use real TitleFormatter in LinkBatchTest

https://gerrit.wikimedia.org/r/1228579

Umherirrender closed this task as Resolved.Jan 19 2026, 8:06 PM

Change #1228585 merged by jenkins-bot:

[mediawiki/core@REL1_44] tests: Use real TitleFormatter in LinkBatchTest

https://gerrit.wikimedia.org/r/1228585

Change #1228589 merged by jenkins-bot: