Page MenuHomePhabricator
Create Task
Maniphest T413920

Using null as an array offset is deprecated, use an empty string instead (from Output/OutputPage.php:4051)
Closed, ResolvedPublic
Actions

Description

  • mediawiki/core locally running PHP 8.5
  • composer phpunit:entrypoint -- --filter OutputPageTest
1) OutputPageTest::testHeadItemsParserOutput
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:534

2) OutputPageTest::testCSPParserOutput
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:562

3) OutputPageTest::testShowNewSectionLink
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:1074

4) OutputPageTest::testForceHideNewSectionLink
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:1095

5) OutputPageTest::testLanguageLinks
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:1210

6) OutputPageTest::testParserOutputCategoryLinks with data set "No categories" (array(), array(), null, array(), array(), array())
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/includes/Output/OutputPage.php:2667
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:1342

7) OutputPageTest::testParserOutputCategoryLinks with data set "Simple test" (array('Some sortkey', 'A different sortkey'), array(stdClass Object (...), stdClass Object (...)), null, array('Test2'), array('Test1'), array('Test1', 'Test2'))
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:1340

8) OutputPageTest::testParserOutputCategoryLinks with data set "Invalid title" (array('[', 'Test'), array(stdClass Object (...)), null, array('Test'), array(), array('Test'))
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/includes/Output/OutputPage.php:2667
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:1342

9) OutputPageTest::testParserOutputCategoryLinks with data set "Variant link" (array('Test', 'Estay'), array(stdClass Object (...)), Closure Object (...), array('Test'), array(), array('tseT'))
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:1340

10) OutputPageTest::testCategoryLinkDeduplication with data set "No categories" (array(), array(), null, array(), array(), array())
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:1380

11) OutputPageTest::testCategoryLinkDeduplication with data set "Simple test" (array('Some sortkey', 'A different sortkey'), array(stdClass Object (...), stdClass Object (...)), null, array('Test2'), array('Test1'), array('Test1', 'Test2'))
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:1380

12) OutputPageTest::testCategoryLinkDeduplication with data set "Invalid title" (array('[', 'Test'), array(stdClass Object (...)), null, array('Test'), array(), array('Test'))
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:1380

13) OutputPageTest::testCategoryLinkDeduplication with data set "Variant link" (array('Test', 'Estay'), array(stdClass Object (...)), Closure Object (...), array('Test'), array(), array('tseT'))
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:1380

14) OutputPageTest::testIndicators
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:1577

15) OutputPageTest::testTemplateIds
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:1782

16) OutputPageTest::testFileSearchOptions
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:1848

17) OutputPageTest::testNoGallery
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:2052

18) OutputPageTest::testAddParserOutputText
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:2079

19) OutputPageTest::testAddParserOutput
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/includes/Output/OutputPage.php:2667
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:2100

20) OutputPageTest::testClientCache
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:2325

21) OutputPageTest::testClickjacking
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:2630

22) OutputPageTest::testIsTOCEnabled
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:3055

23) OutputPageTest::testNoTOC
Using null as an array offset is deprecated, use an empty string instead

/[...]/includes/Output/OutputPage.php:4051
/[...]/includes/Output/OutputPage.php:2464
/[...]/tests/phpunit/includes/Output/OutputPageTest.php:3079

(note: not yet seen in WMF experimental CI due to the order in which it runs MediaWiki's PHPUnit tests, but it presumably would be seen there at some point)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
tests: Mock some functions in OutputPageTestmediawiki/coreREL1_44+7 -0
tests: Mock some functions in OutputPageTestmediawiki/coreREL1_43+7 -0
tests: Mock some functions in OutputPageTestmediawiki/coreREL1_45+8 -0
tests: Mock some functions in OutputPageTestmediawiki/coremaster+8 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

A_smart_kitten created this task.Jan 6 2026, 9:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2026, 9:00 PM
Reedy moved this task from Backlog to MediaWiki core on the PHP 8.5 support board.Jan 6 2026, 9:36 PM
A_smart_kitten mentioned this in T411814: Make PHP 8.5 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI.Jan 12 2026, 11:11 AM
gerritbot added a comment.Jan 17 2026, 12:43 AM

Change #1227971 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Mock some functions in OutputPageTest

https://gerrit.wikimedia.org/r/1227971

gerritbot added a project: Patch-For-Review.Jan 17 2026, 12:43 AM
Umherirrender claimed this task.Jan 17 2026, 12:43 AM
gerritbot added a comment.Jan 17 2026, 7:32 PM

Change #1227971 merged by jenkins-bot:

[mediawiki/core@master] tests: Mock some functions in OutputPageTest

https://gerrit.wikimedia.org/r/1227971

gerritbot added a comment.Jan 17 2026, 7:55 PM

Change #1228234 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_45] tests: Mock some functions in OutputPageTest

https://gerrit.wikimedia.org/r/1228234

gerritbot added a comment.Jan 17 2026, 8:15 PM

Change #1228238 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_44] tests: Mock some functions in OutputPageTest

https://gerrit.wikimedia.org/r/1228238

gerritbot added a comment.Jan 17 2026, 8:32 PM

Change #1228234 merged by jenkins-bot:

[mediawiki/core@REL1_45] tests: Mock some functions in OutputPageTest

https://gerrit.wikimedia.org/r/1228234

gerritbot added a comment.Jan 17 2026, 8:34 PM

Change #1228239 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_43] tests: Mock some functions in OutputPageTest

https://gerrit.wikimedia.org/r/1228239

gerritbot added a comment.Jan 17 2026, 9:19 PM

Change #1228239 merged by jenkins-bot:

[mediawiki/core@REL1_43] tests: Mock some functions in OutputPageTest

https://gerrit.wikimedia.org/r/1228239

gerritbot added a comment.Jan 17 2026, 9:20 PM

Change #1228238 merged by jenkins-bot:

[mediawiki/core@REL1_44] tests: Mock some functions in OutputPageTest

https://gerrit.wikimedia.org/r/1228238

Maintenance_bot removed a project: Patch-For-Review.Jan 17 2026, 9:30 PM
Umherirrender closed this task as Resolved.Jan 17 2026, 10:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits