Using null as the key parameter for array_key_exists() is deprecated, use an empty string instead (from Site/SiteList.php:256)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	A_smart_kitten
	Jan 7 2026, 9:11 AM

Description

mediawiki/core locally running PHP 8.5
composer phpunit:entrypoint -- --filter SiteListTest

1) MediaWiki\Tests\Site\SiteListTest::testSerialization with data set #0 (MediaWiki\Site\SiteList Object (...))
Using null as the key parameter for array_key_exists() is deprecated, use an empty string instead

/[...]/mediawiki/core/includes/Site/SiteList.php:256
/[...]/mediawiki/core/tests/phpunit/includes/Site/SiteListTest.php:198

2) MediaWiki\Tests\Site\SiteListTest::testSerialization with data set #1 (MediaWiki\Site\SiteList Object (...))
Using null as the key parameter for array_key_exists() is deprecated, use an empty string instead

/[...]/mediawiki/core/includes/Site/SiteList.php:256
/[...]/mediawiki/core/tests/phpunit/includes/Site/SiteListTest.php:198

3) MediaWiki\Tests\Site\SiteListTest::testSerialization with data set #2 (MediaWiki\Site\SiteList Object (...))
Using null as the key parameter for array_key_exists() is deprecated, use an empty string instead

/[...]/mediawiki/core/includes/Site/SiteList.php:256
/[...]/mediawiki/core/tests/phpunit/includes/Site/SiteListTest.php:198

(note: not yet seen in WMF experimental CI due to the order in which it runs MediaWiki's PHPUnit tests, but it presumably would be seen there at some point)

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T410514 Using null as array offset or as the key parameter for array_key_exists() is deprecated in PHP 8.5
		Resolved		Umherirrender	T413948 Using null as the key parameter for array_key_exists() is deprecated, use an empty string instead (from Site/SiteList.php:256)

Event Timeline

A_smart_kitten created this task.Jan 7 2026, 9:11 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 7 2026, 9:11 AM

The code in question here is:

includes/Site/SiteList.php; lines 248-257

	/**
	 * Returns if the list contains the site with the provided site id.
	 *
	 * @param int $id
	 *
	 * @return bool
	 */
	public function hasInternalId( $id ) {
		return array_key_exists( $id, $this->byInternalId );
	}

tests/phpunit/includes/Site/SiteListTest.php; line 198

			$this->assertTrue( $copy->hasInternalId( $site->getInternalId() ) );

A_smart_kitten mentioned this in T413579: Using null as an array offset is deprecated, use an empty string instead in SiteList.Jan 7 2026, 9:20 AM

A_smart_kitten added a parent task: T410514: Using null as array offset or as the key parameter for array_key_exists() is deprecated in PHP 8.5.

A_smart_kitten mentioned this in T411814: Make PHP 8.5 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI.Mon, Jan 12, 11:11 AM

Fixed as part of T413579

Using null as the key parameter for array_key_exists() is deprecated, use an empty string instead (from Site/SiteList.php:256)Closed, ResolvedPublicActions

Description

Related ObjectsSearch...

Event Timeline

Using null as the key parameter for array_key_exists() is deprecated, use an empty string instead (from Site/SiteList.php:256)
Closed, ResolvedPublic
Actions

Related Objects
Search...