Page MenuHomePhabricator

TypeError: Cannot read properties of null (reading 'appendChild') in mountContributionsAddDialog
Closed, ResolvedPublicPRODUCTION ERROR

Description

Seen on subpages of https://meta.wikimedia.org/wiki/Special:EventDetails (all skins)
1,025 errors in last 7 days
https://logstash.wikimedia.org/goto/20f8f992be70534f04c2b9699066f296

Stack trace:

at HTMLDocument.mountContributionsAddDialog  https://meta.wikimedia.org/w/load.php?lang=fi&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.campaignEvents.specialPages%7Cext.checkUser.userInfoCard%7Cjquery.makeCollapsible%2CtextSelection%7Cjquery.makeCollapsible.styles%7Cmediawiki.DateFormatter%7Cmediawiki.editfont.styles%7Cmediawiki.widgets.DateTimeInputWidget.styles%7Cmediawiki.widgets.UsersMultiselectWidget%2Cdatetime&skin=vector&version=1oqtt:385:910
at mightThrow  https://meta.wikimedia.org/w/load.php?lang=fi&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.campaignEvents.specialPages%7Cext.checkUser.userInfoCard%7Cjquery.makeCollapsible%2CtextSelection%7Cjquery.makeCollapsible.styles%7Cmediawiki.DateFormatter%7Cmediawiki.editfont.styles%7Cmediawiki.widgets.DateTimeInputWidget.styles%7Cmediawiki.widgets.UsersMultiselectWidget%2Cdatetime&skin=vector&version=1oqtt:47:983
at process  https://meta.wikimedia.org/w/load.php?lang=fi&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.campaignEvents.specialPages%7Cext.checkUser.userInfoCard%7Cjquery.makeCollapsible%2CtextSelection%7Cjquery.makeCollapsible.styles%7Cmediawiki.DateFormatter%7Cmediawiki.editfont.styles%7Cmediawiki.widgets.DateTimeInputWidget.styles%7Cmediawiki.widgets.UsersMultiselectWidget%2Cdatetime&skin=vector&version=1oqtt:48:643

Steps to replicate the issue (include links if applicable):

What happens?:

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Restricted Application changed the subtype of this task from "Bug Report" to "Production Error". · View Herald Transcript
Restricted Application added a project: Connection-Team. · View Herald Transcript
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1225707 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] resources: Do not load EventContributions.js when there's no contributions tab

https://gerrit.wikimedia.org/r/1225707

Change #1225707 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] resources: Don't load EventContributions.js when there's no contributions tab

https://gerrit.wikimedia.org/r/1225707

ldelench_wmf subscribed.

Hey @Daimona, testing on https://test.wikipedia.org/wiki/Special:EventDetails/195, here's what I see in the console:

error in expose login TypeError: Cannot read properties of undefined (reading 'getId')

at exposeLoginInDOM (VM1009 contentScript.bundle.js:106:26)
at VM1009 contentScript.bundle.js:143:11

[CdxPopover]: The "anchor" prop must be provided to position the CdxPopover.

The stream mediawiki.client.session_tick is out of sample. No event will be sent

{F71778539}

Hey @Daimona, testing on https://test.wikipedia.org/wiki/Special:EventDetails/195, here's what I see in the console:

error in expose login TypeError: Cannot read properties of undefined (reading 'getId')

at exposeLoginInDOM (VM1009 contentScript.bundle.js:106:26)
at VM1009 contentScript.bundle.js:143:11

[CdxPopover]: The "anchor" prop must be provided to position the CdxPopover.

The stream mediawiki.client.session_tick is out of sample. No event will be sent

Yeah, these seem to be all from other components. Ideally they shouldn't be there, but none of them seems to be from our code.

{F71778539}

FYI, this file is not visible because it's not attached to the task.

I've re-tested this.

error in expose login TypeError: Cannot read properties of undefined (reading 'getId')

at exposeLoginInDOM (VM1009 contentScript.bundle.js:106:26)
at VM1009 contentScript.bundle.js:143:11

No longer seeing this.

[CdxPopover]: The "anchor" prop must be provided to position the CdxPopover.

That is T405025 (CheckUser-UserInfoCard).

The stream mediawiki.client.session_tick is out of sample. No event will be sent

That is T416058 (Test Kitchen).


Closing, as the original issue was resolved.