Page MenuHomePhabricator

Gerrit comments for patch abandonments without a provided reason are displayed with a green icon (indicating a merged patch) rather than a red icon (indicating an abandoned patch)
Open, LowPublicBUG REPORT

Description

Steps to replicate the issue
Navigate to https://phabricator.wikimedia.org/T413706#11497665

What happens?
The @gerritbot/Git icon on the left is displayed in green (indicating that the patch has been merged).

Screenshot 2026-01-07 at 19.26.00.png (600×2 px, 113 KB)

What should have happened instead?
As the patch has been abandoned (rather than merged), the icon should be displayed in red.
(phui-timeline-view-wikimedia.css#L187-200 has some information in the CSS's comments about what the icon's colours are 'intended' to represent)

Other information
cc @matmarex FYI as the new styles' author
I think I remember having worked-around this locally (on a different device) before the styles were deployed with Phabricator itself, but (IIRC) the work-around I used might have involved JavaScript...

Event Timeline

I'm aware of this problem and as far as I can tell, it's impossible to fix in just CSS, as the HTML structure of these comments is exactly the same as the "merge" comments – only the text differs.

Aklapper moved this task from To Triage to Misc on the Phabricator board.
Aklapper added a project: CSS.

Does that mean this is Declined?

I would personally say 'no' (although I obviously filed the task, lol). IMO this is a UX issue that should be solved if possible.
As to how this might be solved, I've had some ideas about potentially adding some custom WMF/downstream code in the PHP file(s) that parse Remarkup, to potentially see if some extra/custom HTML classes could be added there that might then be able to be picked up by the new gerritbot CSS. I haven't yet had a chance to properly investigate that possibility, but IMO it feels like it might be a possibility.