Page MenuHomePhabricator

Upgrade Codex to v1.18.0 in VE core
Closed, ResolvedPublic

Description

In order to use new design tokens to properly reflect dark mode settings in VE, it would be helpful to use v1.18.0 or newer.

Event Timeline

Change #1224746 had a related patch set uploaded (by Aarohisharma3; author: Aarohisharma3):

[VisualEditor/VisualEditor@master] Update Codex Design Tokens to v1.18.0

https://gerrit.wikimedia.org/r/1224746

I've upgraded the vendored Codex Design Tokens from v1.6.1 to v1.18.0 using the update-codex.sh script. All builds and tests pass successfully.

Gerrit patch: https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/1224746

This upgrade provides the necessary tokens for proper dark mode support, as mentioned in the task description. The update includes 343 new lines and removes 311 lines in the design tokens file.

Thanks!
Happy to help move this forward. Let me know if you'd like me to make any adjustments to the patch.

I wrote a quick script to check which variables are used in ve-core:

Used variables:
  @border-subtle (7)
    - src/init/sa/styles/ve.init.sa.less
    - src/ui/styles/contextitems/ve.ui.LinearContextItem.less
    - src/ui/styles/contextitems/ve.ui.LinkContextItem.less
    - src/ui/styles/ve.ui.ContextItem.less
    - src/ui/styles/ve.ui.MobileContext.less
    - src/ui/styles/ve.ui.Toolbar.less
  @background-color-base (3)
    - src/themes/wikimediaui.less
    - src/ui/styles/dialogs/ve.ui.ToolbarDialog.less
    - src/ui/styles/ve.ui.MobileContext.less
  @border-radius-base (2)
    - src/themes/wikimediaui.less
    - src/ui/styles/layouts/ve.ui.SymbolListBookletLayout.less
  @transition-duration-medium (2)
    - src/themes/wikimediaui.less
  @background-color-interactive (1)
    - src/ui/styles/layouts/ve.ui.SymbolListBookletLayout.less
  @background-color-neutral-subtle (1)
    - src/themes/wikimediaui.less
  @border-base (1)
    - src/themes/wikimediaui.less
  @border-color-progressive--focus (1)
    - src/themes/wikimediaui.less
  @box-shadow-color-progressive--focus (1)
    - src/themes/wikimediaui.less
  @box-shadow-inset-small (1)
    - src/themes/wikimediaui.less
  @color-subtle (1)
    - src/ui/styles/layouts/ve.ui.SymbolListBookletLayout.less

Of these only one is changed by the above patch:

--- @border-color-progressive: var( --border-color-progressive, #36c );
+++ @border-color-progressive: var( --border-color-progressive, #6485d1 );

This is used by the TargetWidget focus state and should be updated to match the focus box-shadow colour.

Change #1228458 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] TargetWidget: Update variable used by focus state

https://gerrit.wikimedia.org/r/1228458

It looks like updating to 2.3.3 would to result in any more changes to variables we use so that should be safe to do.

Change #1228458 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] TargetWidget: Update variable used by focus state

https://gerrit.wikimedia.org/r/1228458

Change #1224746 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Update Codex Design Tokens to v2.3.3

https://gerrit.wikimedia.org/r/1224746

Change #1230406 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6ffac7f7f)

https://gerrit.wikimedia.org/r/1230406

Change #1230406 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6ffac7f7f)

https://gerrit.wikimedia.org/r/1230406