Page MenuHomePhabricator

Add fake classes to every entry part
Closed, ResolvedPublicFeature

Description

Hi. I'm going to add a fake class for every part of the entry, where it isn't there yet. For example, it could be something like

<a class="gwl-history" ...>...</a>

for the page history link. The reason is to allow the users the ability for free customization of the entries in their common.css.

Event Timeline

Hmm what is "fake" about these classes?
In any case, existing CSS classes in the GlobalWatchlist codebase seem to use the pattern ext-globalwatchlist-*. There is no gwl-*, as far as I know.

Hmm what is "fake" about these classes?

That they are just names, without actual styles in the .less file.

In any case, existing CSS classes in the GlobalWatchlist codebase seem to use the pattern ext-globalwatchlist-*. There is no gwl-*, as far as I know.

Yes, it was just an example for clarity, I'm not going to break the pattern, of course.

Change #1225069 had a related patch set uploaded (by IKhitron; author: IKhitron):

[mediawiki/extensions/GlobalWatchlist@master] Add fake CSS classes to all entry parts

https://gerrit.wikimedia.org/r/1225069

Test wiki created on Patch demo by IKhitron using patch(es) linked to this task:
https://7756675db2.catalyst.wmcloud.org/w/

IKhitron triaged this task as High priority.
IKhitron moved this task from Planned to Ready to review on the User-IKhitron board.

Change #1225069 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] Add missing CSS classes to all entry parts

https://gerrit.wikimedia.org/r/1225069

IKhitron moved this task from Ready to review to Merged on the User-IKhitron board.