Page MenuHomePhabricator
Create Task
Maniphest T414143

Update storage layer for event goals
Closed, ResolvedPublic
Actions

Description

  • Create a new EventGoalsStore which also handles the JSON serializing and deserializing
  • Use that in EventStore (read and write)
  • Reads and writes to the new table should be behind a feature flag

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update storage layer for event goalsCmelomediawiki/extensions/CampaignEventsmaster+277 -7
Add feature flag CampaignEventsEnableEventGoalsCmelomediawiki/extensions/CampaignEventsmaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

ifried created this task.Jan 8 2026, 11:11 PM
Daimona renamed this task from Storage layer / DB code (EventStore; a new EventGoalsStore which also handles the JSON parsing) to Update storage layer for event goals.Jan 13 2026, 10:39 PM
Daimona updated the task description. (Show Details)
Daimona updated the task description. (Show Details)Jan 13 2026, 10:52 PM
Daimona edited projects, added: Connection-Team (Connection-Current-Sprint); removed: Connection-Team.Jan 14 2026, 5:27 PM
Daimona moved this task from Upcoming / refining 💡 to Ready for development on the Connection-Team (Connection-Current-Sprint) board.
cmelo changed the task status from Open to In Progress.Jan 29 2026, 4:30 AM
cmelo claimed this task.
cmelo moved this task from Ready for development to Development In Progress 💻 on the Connection-Team (Connection-Current-Sprint) board.
gerritbot added a comment.Jan 29 2026, 3:14 PM

Change #1235052 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Add feature flag CampaignEventsEnableEventGoals

https://gerrit.wikimedia.org/r/1235052

gerritbot added a project: Patch-For-Review.Jan 29 2026, 3:14 PM

Change #1235053 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Update storage layer for event goals

https://gerrit.wikimedia.org/r/1235053

gerritbot added a comment.Jan 29 2026, 4:55 PM

Change #1235052 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add feature flag CampaignEventsEnableEventGoals

https://gerrit.wikimedia.org/r/1235052

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.14; 2026-02-03).Jan 29 2026, 5:00 PM
cmelo moved this task from Development In Progress 💻 to Code Review 💬 on the Connection-Team (Connection-Current-Sprint) board.Feb 2 2026, 12:40 PM
cmelo moved this task from Code Review 💬 to Development In Progress 💻 on the Connection-Team (Connection-Current-Sprint) board.Feb 3 2026, 7:54 AM
cmelo moved this task from Development In Progress 💻 to Code Review 💬 on the Connection-Team (Connection-Current-Sprint) board.Feb 3 2026, 3:49 PM
gerritbot added a comment.Mar 3 2026, 1:33 PM

Change #1235053 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Update storage layer for event goals

https://gerrit.wikimedia.org/r/1235053

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.19; 2026-03-10); removed: MW-1.46-notes (1.46.0-wmf.14; 2026-02-03).Mar 3 2026, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 3 2026, 2:31 PM
cmelo moved this task from Code Review 💬 to QA 🐛 on the Connection-Team (Connection-Current-Sprint) board.Mar 5 2026, 9:18 AM
Daimona closed this task as Resolved.Mar 11 2026, 10:21 PM
Daimona moved this task from QA 🐛 to Done 🏁 on the Connection-Team (Connection-Current-Sprint) board.
Daimona subscribed.

Create a new EventGoalsStore which also handles the JSON serializing and deserializing

✅ It's called EventGoalStore but obviously it's the same.

Use that in EventStore (read and write)

✅ It's there

Reads and writes to the new table should be behind a feature flag

✅ Via the isEventGoalFeatureEnabled() method.

Not user-facing, marking as done.

VPuffetMichel added a project: OKR-Work.Apr 3 2026, 8:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits