| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add goals to API endpoints. | mediawiki/extensions/CampaignEvents | master | +64 -8 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T387389 [EPIC] Event goal-setting in Collaborative Contributions | |||
| Resolved | MHorsey-WMF | T414146 Update API layer for event goals |
Change #1248782 had a related patch set uploaded (by Mhorsey; author: Mhorsey):
[mediawiki/extensions/CampaignEvents@master] Add goals to API endpoints.
Change #1248782 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Add goals to API endpoints.
- The "Enable an event registration" endpoint should accept a new field to specify the event goals
✅ goal_type and goal_target parameters have been introduced and they allow setting goals. (Validation tested as part of T414144)
- The "Edit an event registration" endpoint should accept a new field to specify the event goals
✅ goal_type and goal_target parameters have been introduced and they allow setting goals. (Validation tested as part of T414144)
- The "Get details of an event" endpoint response should include the event goals in the same format as the other two endpoints (i.e., not the goal completion percentage)
✅ The response includes goal_type and goal_target in the same format as the write endpoints.
- These changes should be behind a feature flag
✅⚠️ For the write endpoints, this is implemented correctly, and the goal_* parameters are rejected as extraneous with the flag turned off. The GET endpoint however always includes them in the response. That's probably OK though, they're just always null.
❌ Documentation was not updated. I'll do it shortly.