Page MenuHomePhabricator

Remove default value from gbw_by in global_block_whitelist table on WMF wikis
Closed, ResolvedPublic

Description

  1. ALTERs to run:
ALTER TABLE /*_*/global_block_whitelist
  CHANGE gbw_by gbw_by INT NOT NULL;
  1. Where to run those changes: all.dblist (though likely only a subset of this list actually needs the update applied)
  2. When to run those changes: When DBA has time, very low priority
  3. If the schema change is backwards compatible: Yes
  4. If the schema change has been tested already on some of the test/beta wikis: The beta wikis do not have a default set for gbw_by
  5. If the data should be made available on the labs replicas and/or dumps: Yes, no changes to existing rules needed

As detailed in T381502: Fix GlobalBlocking database schema drifts in production, the gbw_by column has a default set on WMF wikis but the GlobalBlocking extension schema has this without a default set. Looking further, it seems that there was no default set in the SQL that was defined before the conversion to an abstract schema, so it seems that we shouldn't need a patch to GlobalBlocking to address this.

Progress

  • s1
  • s2
  • s3
  • s4
  • s5
  • s6
  • s7
  • s8

Acceptance criteria

  • The default value on gbw_by is removed from the global_block_whitelist table on all wikis

Event Timeline

Mentioned in SAL (#wikimedia-operations) [2026-01-09T12:19:02Z] <marostegui> Deploy schema change on s6 primary master T414183

Marostegui triaged this task as Medium priority.
Marostegui updated the task description. (Show Details)

Mentioned in SAL (#wikimedia-operations) [2026-01-09T12:23:47Z] <marostegui> Deploy schema change on s2 primary master T414183

Mentioned in SAL (#wikimedia-operations) [2026-01-09T12:32:32Z] <marostegui> Deploy schema change on s7 primary master T414183

Mentioned in SAL (#wikimedia-operations) [2026-01-09T12:37:58Z] <marostegui> Deploy schema change on s5 primary master T414183

Mentioned in SAL (#wikimedia-operations) [2026-01-09T13:02:48Z] <marostegui> Deploy schema change on s1 primary master T414183

Mentioned in SAL (#wikimedia-operations) [2026-01-09T13:03:23Z] <marostegui> Deploy schema change on s8 primary master T414183

Mentioned in SAL (#wikimedia-operations) [2026-01-09T13:04:07Z] <marostegui> Deploy schema change on s4 primary master T414183

s4 is done, but a couple of replicas (one in codfw and one in eqiad) will take a few more hours to get the change, as they are delayed many hours due to a different schema change running on them with replication stopped.

Mentioned in SAL (#wikimedia-operations) [2026-01-09T13:10:45Z] <marostegui> Deploy schema change on s3 primary master (this will take a few hours) T414183

s3 is on-going, it will take a few hours.

Marostegui updated the task description. (Show Details)

This is done