Page MenuHomePhabricator

Add link filter to TextMatchEditCheck?
Closed, DeclinedPublic

Description

We probably don't want to match links in TextMatchEditCheck, especially if the title of the link and the place it points to are the same.

  • Establish with team whether to implement this at all
    • Not right now
  • Decision: Do we write a special-case filter for titles of other articles? Is it on by default?
  • Decision: Do we write a general-case filter to allow certain node types to be included/excluded?
  • Update description for implementation

Event Timeline

zoe updated the task description. (Show Details)

We discussed the merits of this and concluded that this would probably not be a useful heuristic because there are many cases (such as chemical elements) where we would want the en_GB spelling. Avoiding proper nouns (in English, by looking for title cased words) is likely to cover these cases more accurately.

There might be a use for excluding matches based on annotations, but we should wait until a specific need arises.