Page MenuHomePhabricator

Reconsider/improve the array indentation rule in the reuse team specific phpcs ruleset
Closed, ResolvedPublic

Description

We have enabled the Generic.Arrays.ArrayIndent rule, which does some useful things, but also comes with the Generic.Arrays.ArrayIndent.CloseBraceNotNewLine rule which seems excessive. It forbids e.g. the following formatting:

$foo = [ 'data' => [
	'id' => 'Q123',
] ];

It also does strange things when auto "fixing" violations of the rule via phpcbf.

Event Timeline

Change #1227358 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Disable ArrayIndent.CloseBraceNotNewLine phpcs rule

https://gerrit.wikimedia.org/r/1227358

Change #1227358 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Disable ArrayIndent.CloseBraceNotNewLine phpcs rule

https://gerrit.wikimedia.org/r/1227358