Page MenuHomePhabricator
Create Task
Maniphest T414246

Watchlist displays multiple 'edit watchlist' links (when wlenhancedfilters-disable is not true and skin is not using deprecated menus)
Closed, ResolvedPublicBUG REPORT
Actions

Description

Spinning out from {T409774#11508807} there is a misconfiguration in recent changes.

Steps to replicate the issue (include links if applicable):

What happens?:
Two links to watchlist

image.png (246×1 px, 42 KB)

What should have happened instead?:
The right side link is added by core RCFilters App but only for skins that don't have the top bar. This should check for the presence of $('#p-associated-pages').length to avoid duplication.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Note this bug will spread to other skins including legacy Vector too without any fix.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Do not duplicate edit watchlist link on skins which already have itmediawiki/coremaster+3 -2
Use p-associated-pages ID instead of p-namespacesmediawiki/skins/Timelessmaster+4 -4
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson-WMF created this task.Jan 9 2026, 11:39 PM
Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptJan 9 2026, 11:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson-WMF renamed this task from Timeless has two 'edit watchlist' links on Watchlist page (when wlenhancedfilters-disable is not true): to Recent Changes displays multiple 'edit watchlist' links on Watchlist page (when wlenhancedfilters-disable is not true and skin is not using deprecated menus).Jan 9 2026, 11:40 PM
Jdlrobson-WMF updated the task description. (Show Details)
Jdlrobson subscribed.Jan 10 2026, 4:11 PM

Code in question is here: https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.rcfilters/ui/WatchlistTopSectionWidget.js#L55-L66
Relying on skin will not be very feature proof as skins evolve.

Jdlrobson-WMF mentioned this in T409774: Deprecate legacy "personal" and "namespaces" menu from SkinTemplate.Jan 12 2026, 4:44 PM
Ammarpad subscribed.Jan 12 2026, 5:55 PM

Yes, checking #p-associated-pages would be more correct. However, Timeless itself does not have the id now, it needs to be fixed.

gerritbot added a comment.Jan 12 2026, 6:04 PM

Change #1225625 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Timeless@master] Use p-associated-pages ID instead of p-namespaces

https://gerrit.wikimedia.org/r/1225625

gerritbot added a project: Patch-For-Review.Jan 12 2026, 6:04 PM
Samwalton9-WMF attached a referenced file: F71115332: image.png. (Show Details)Jan 13 2026, 8:24 AM
Samwalton9-WMF moved this task from Inbox to Code review requests on the Moderator-Tools-Team board.
Jdlrobson-WMF renamed this task from Recent Changes displays multiple 'edit watchlist' links on Watchlist page (when wlenhancedfilters-disable is not true and skin is not using deprecated menus) to Watchlist displays multiple 'edit watchlist' links (when wlenhancedfilters-disable is not true and skin is not using deprecated menus).Jan 13 2026, 10:51 PM
gerritbot added a comment.Jan 14 2026, 5:53 PM

Change #1226916 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Do not duplicate edit watchlist link on skins which already have it

https://gerrit.wikimedia.org/r/1226916

Jdlrobson-WMF added a subscriber: Samwalton9-WMF.EditedJan 14 2026, 5:54 PM

@Samwalton9-WMF note this is now impacting Monobook as well as Timeless. I posted a suggested fix.

gerritbot added a comment.Jan 14 2026, 6:43 PM

Change #1225625 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] Use p-associated-pages ID instead of p-namespaces

https://gerrit.wikimedia.org/r/1225625

Dillon edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.Jan 29 2026, 3:28 PM
Dillon moved this task from Ready to QA on the Moderator-Tools-Team (Kanban) board.
Samwalton9-WMF moved this task from QA to Eng review on the Moderator-Tools-Team (Kanban) board.Feb 6 2026, 3:14 PM

Timeless patch is merged but Core patch still requires review.

gerritbot added a comment.Feb 10 2026, 10:42 AM

Change #1226916 merged by jenkins-bot:

[mediawiki/core@master] Do not duplicate edit watchlist link on skins which already have it

https://gerrit.wikimedia.org/r/1226916

Samwalton9-WMF moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Feb 10 2026, 10:48 AM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.16; 2026-02-17).Feb 10 2026, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 10 2026, 11:30 AM
jsn.sherman moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.Feb 25 2026, 6:40 PM
jsn.sherman subscribed.

verified working on testwiki

jsn.sherman closed this task as Resolved.Feb 25 2026, 6:40 PM
jsn.sherman claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits