Page MenuHomePhabricator

Thanks notifications fail to render i18n messages in edit summaries (GrowthExperiments, Wikibase, ...)
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue:

What happens?:

  • The user's thanks notification looks like this:

Screenshot 2026-01-08 at 20.13.35.png (246×1 px, 51 KB)

What should have happened instead?:

Screenshot 2026-01-10 at 08.55.36.png (236×984 px, 44 KB)

Other information:

  • I'm guessing that happens, because the growth edit summary is not plain text, changing your language settings changes how the edit summary is displayed in the page history. But how should a newbie understand the text displayed in the thanks notification?

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1225102 had a related patch set uploaded (by SarthakSingh2904; author: SarthakSingh2904):

[mediawiki/extensions/Thanks@master] Echo: Format edit summary in new contributor thanks notification

https://gerrit.wikimedia.org/r/1225102

Hello, I’ve implemented the requested changes. Kindly review them and let me know if anything needs adjustment.
Thank you. @Johannnes89

Change #1225102 abandoned by SarthakSingh2904:

[mediawiki/extensions/Thanks@master] Echo: Format edit summary in new contributor thanks notification

https://gerrit.wikimedia.org/r/1225102

Michael subscribed.

Thanks for raising this. Not sure yet if this is an issue in Thanks or in Add Link / Growth Experiments.

This seems to be an issue in the Thanks extension.

In \MediaWiki\Extension\Thanks\EchoCoreThanksPresentationModel::getRevOrLogComment the edit-summary comment is returned as plain text instead of using CommentFormatter, and thus the hooke to render this i18n message in GrowthExperiments does not run.

I'll leave this for the Connection-Team to prioritize.

This is also affecting all other extensions that use i18n messages in edit-summaries, for example Wikibase:

image.png (127×696 px, 14 KB)

Michael renamed this task from Thanks notifications display an unusual edit summary when thanking users for newcomer task edits to Thanks notifications fail to render i18n messages in edit summaries (GrowthExperiments, Wikibase, ...).Jan 14 2026, 12:44 PM
Michael removed a project: Growth-Team.