Page MenuHomePhabricator

undo/restore may fail due to sitelink conflicts
Closed, ResolvedPublic

Description

If item A once linked to dewiki:Foo but now links to dewiki:Bar, and item B now links to dewiki:Foo, item A can not be restored to the old revision that points to dewiki:Foo.

This type of global-consistency conflict should be checked when preparing the undo/restore operation, just like "local" conflicts that arise from later edits of the item. The respective change to the sitelinks should be omitted, and this should be reported to the user.

Implementation note: care should be taken that this works on the restore as well as the undo codepath - the restore codepath so far bypasses checks for conflicting edits.

Reminder: fix broken error message that is shown when a sitelink conflict causes save to fail.


Version: master
Severity: enhancement

Details

Reference
bz39428

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:54 AM
bzimport set Reference to bz39428.
bzimport added a subscriber: Unknown Object (MLST).

see also bug 38958 for filtering based on global consistency constraints.

Confirmed that undo/restore fails if a conflict would arise, but no database inconsistencies arise from this, and a meaningful error is shown to the user.

Automatically filtering out conflicting things from the item remains as a feature request.