unexpected NAN value was coerced to string (from Language/Language.php:3543)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	A_smart_kitten
	Jan 12 2026, 3:10 PM

Description

Cross-reference https://wiki.php.net/rfc/warnings-php-8-5#coercing_nan_to_other_types

mediawiki/core (47e8bf1baf66) locally, running PHP 8.5
composer phpunit:entrypoint -- --filter LanguageIntegrationTest

1) MediaWiki\Tests\Language\LanguageIntegrationTest::testFormatNum with data set #34 (true, 'en', NAN, false, 'Not a Number')
unexpected NAN value was coerced to string

/[...]/mediawiki/core/includes/Language/Language.php:3543
/[...]/mediawiki/core/tests/phpunit/includes/Language/LanguageIntegrationTest.php:2052

2) MediaWiki\Tests\Language\LanguageIntegrationTest::testParseFormattedNumber with data set #11 ('en', NAN)
unexpected NAN value was coerced to string

/[...]/mediawiki/core/includes/Language/Language.php:3543
/[...]/mediawiki/core/tests/phpunit/includes/Language/LanguageIntegrationTest.php:2134

(note: not yet seen in WMF experimental CI due to the order in which it runs MediaWiki's PHPUnit tests, but it presumably would be seen there at some point)

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Language: Handle NAN coercion to string in formatting numbers.	mediawiki/core	REL1_43	+21 -14
Language: Handle NAN coercion to string in formatting numbers.	mediawiki/core	REL1_44	+21 -14
Language: Handle NAN coercion to string in formatting numbers.	mediawiki/core	REL1_45	+21 -14
Language: Handle NAN coercion to string in formatting numbers.	mediawiki/core	master	+21 -14
Language: Accept NAN, INF, -INF on Language::formatNum under php8.5	mediawiki/core	master	+27 -4
tests: Provide NAN as string in LanguageIntegrationTest	mediawiki/core	master	+3 -3

Customize query in gerrit

Related Objects

Mentioned In: T415361: "unexpected NAN value was coerced to string" PHP warning from LanguageIntegrationTest::testParseFormattedNumber `assertEquals` call
T411814: Make PHP 8.5 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI
Mentioned Here: rMW47e8bf1baf66: OutputTransform: Use ParserOptions instead of Skin to get user language

Event Timeline

A_smart_kitten created this task.Jan 12 2026, 3:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2026, 3:10 PM

A_smart_kitten moved this task from Backlog to MediaWiki core on the PHP 8.5 support board.Jan 12 2026, 5:57 PM

Akaza24 subscribed.Jan 12 2026, 6:43 PM

Akaza24 unsubscribed.Jan 12 2026, 6:50 PM

Akaza24 subscribed.

Change #1225648 had a related patch set uploaded (by Akaza24; author: Akaza24):

[mediawiki/core@master] Fix NAN coercion warning in formatNum methods

https://gerrit.wikimedia.org/r/1225648

gerritbot added a project: Patch-For-Review.Jan 12 2026, 7:09 PM

ShivaanshSingh subscribed.Jan 13 2026, 5:41 AM

A_smart_kitten mentioned this in T411814: Make PHP 8.5 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI.Jan 13 2026, 1:37 PM

Change #1225648 merged by jenkins-bot:

[mediawiki/core@master] tests: Provide NAN as string in LanguageIntegrationTest

https://gerrit.wikimedia.org/r/1225648

Maintenance_bot removed a project: Patch-For-Review.Jan 16 2026, 2:31 PM

Akaza24 claimed this task.Jan 16 2026, 5:49 PM

Akaza24 removed Akaza24 as the assignee of this task.

Akaza24 added a project: RoadToWiki.

There is also

20:35:58 1) MediaWiki\Tests\Language\LanguageIntegrationTest::testParseFormattedNumber with data set #11 ('en', NAN)
20:35:58 unexpected NAN value was coerced to string
20:35:58 
20:35:58 /workspace/src/includes/Language/Language.php:3542
20:35:58 /workspace/src/tests/phpunit/includes/Language/LanguageIntegrationTest.php:2134

IMO it was a mistake that the previous patch just fixed the (other) test by modifying the value that the test itself was passing to Language::formatNum, rather than fixing - AFAICS - the actual compatibility issue when passing NAN to that function on PHP 8.5.

Change #1228139 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Language: Accept NAN, INF, -INF on Language::formatNum under php8.5

https://gerrit.wikimedia.org/r/1228139

gerritbot added a project: Patch-For-Review.Jan 17 2026, 11:54 AM

Change #1228139 abandoned by Umherirrender:

[mediawiki/core@master] Language: Accept NAN, INF, -INF on Language::formatNum under php8.5

Reason:

Going with I38f9fc1d2cecc0b25dca09351166a8f9aedf5ae2

https://gerrit.wikimedia.org/r/1228139

Maintenance_bot removed a project: Patch-For-Review.Jan 17 2026, 11:30 PM

Change #1228173 had a related patch set uploaded (by Jforrester; author: Ammarpad):

[mediawiki/core@master] Language: Handle NAN coercion to string in formatting numbers.

https://gerrit.wikimedia.org/r/1228173

gerritbot added a project: Patch-For-Review.Jan 21 2026, 9:08 PM

Change #1228173 merged by jenkins-bot:

[mediawiki/core@master] Language: Handle NAN coercion to string in formatting numbers.

https://gerrit.wikimedia.org/r/1228173

Maintenance_bot removed a project: Patch-For-Review.Jan 21 2026, 9:30 PM

Change #1229785 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/core@REL1_45] Language: Handle NAN coercion to string in formatting numbers.

https://gerrit.wikimedia.org/r/1229785

Change #1229786 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/core@REL1_44] Language: Handle NAN coercion to string in formatting numbers.

https://gerrit.wikimedia.org/r/1229786

Change #1229787 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/core@REL1_43] Language: Handle NAN coercion to string in formatting numbers.

https://gerrit.wikimedia.org/r/1229787

Change #1229785 merged by jenkins-bot:

[mediawiki/core@REL1_45] Language: Handle NAN coercion to string in formatting numbers.

https://gerrit.wikimedia.org/r/1229785

Change #1229786 merged by jenkins-bot:

[mediawiki/core@REL1_44] Language: Handle NAN coercion to string in formatting numbers.

https://gerrit.wikimedia.org/r/1229786

Reedy closed this task as Resolved.Jan 22 2026, 12:54 AM

Reedy assigned this task to Ammarpad.

Change #1229787 merged by jenkins-bot: