Page MenuHomePhabricator
Create Task
Maniphest T414359

Use postprocessing cache in FlaggedRevisions
Closed, ResolvedPublic
Actions

Description

Currently FlaggedRevisions bypasses the ParserOutputAccess optimizations which enabled the postprocessing cache.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Move post-processing of flaggedrevs views inside FlaggablePageViewIsabelle Hurbain-Palatinmediawiki/extensions/FlaggedRevsmaster+3 -1
Refactor FlaggedRevsParserCache to get them through a factoryIsabelle Hurbain-Palatinmediawiki/extensions/FlaggedRevsmaster+62 -30
Add postprocessing cache for FlaggedRevsIsabelle Hurbain-Palatinmediawiki/extensions/FlaggedRevsmaster+117 -123
Move postprocessing of flaggedrev views inside FlaggablePageView, take 2Isabelle Hurbain-Palatinmediawiki/extensions/FlaggedRevsmaster+6 -1
Refactor ParserCache-related tests with a common cache creationIsabelle Hurbain-Palatinmediawiki/coremaster+134 -142
Use FlaggedRevsParserCacheFactory to access the flaggedrevs cacheIsabelle Hurbain-Palatinmediawiki/extensions/Kartographermaster+14 -10
Add a test to check FlaggedRevs cache behaviourIsabelle Hurbain-Palatinmediawiki/extensions/FlaggedRevsmaster+85 -0
Add spy classes for ParserCache to be able to test FlaggedRevsCacheIsabelle Hurbain-Palatinmediawiki/coremaster+58 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

cscott created this task.Jan 12 2026, 4:25 PM
cscott moved this task from Backlog to In Progress on the Content-Platform-Team (Work In Progress) board.Jan 26 2026, 4:14 PM
gerritbot added a comment.Feb 13 2026, 5:17 PM

Change #1239378 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/FlaggedRevs@master] Move post-processing of flaggedrevs views inside FlaggablePageView

https://gerrit.wikimedia.org/r/1239378

gerritbot added a project: Patch-For-Review.Feb 13 2026, 5:17 PM
A_smart_kitten edited projects, added: FlaggedRevs; removed: MW-1.46-notes (1.46.0-wmf.7; 2025-12-16).Feb 16 2026, 7:23 AM
cscott moved this task from In Progress to Code Review on the Content-Platform-Team (Work In Progress) board.Feb 17 2026, 3:40 PM
gerritbot added a comment.Feb 24 2026, 5:29 PM

Change #1239379 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/FlaggedRevs@master] Add postprocessing cache for FlaggedRevs

https://gerrit.wikimedia.org/r/1239379

gerritbot added a comment.Feb 26 2026, 6:23 PM

Change #1244742 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Add spy classes for ParserCache to be able to test FlaggedRevsCache

https://gerrit.wikimedia.org/r/1244742

gerritbot added a comment.Feb 26 2026, 6:24 PM

Change #1243124 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/FlaggedRevs@master] Add a test to check FlaggedRevs cache behaviour

https://gerrit.wikimedia.org/r/1243124

gerritbot added a comment.Feb 26 2026, 6:24 PM

Change #1244744 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/FlaggedRevs@master] Refactor FlaggedRevsParserCache to get them through a factory

https://gerrit.wikimedia.org/r/1244744

gerritbot added a comment.Feb 26 2026, 6:24 PM

Change #1244745 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Kartographer@master] Use FlaggedRevsParserCacheFactory to access the flaggedrevs cache

https://gerrit.wikimedia.org/r/1244745

gerritbot added a comment.Feb 26 2026, 9:37 PM

Change #1244742 merged by jenkins-bot:

[mediawiki/core@master] Add spy classes for ParserCache to be able to test FlaggedRevsCache

https://gerrit.wikimedia.org/r/1244742

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.18; 2026-03-03).Feb 26 2026, 10:00 PM
gerritbot added a comment.Mar 2 2026, 5:26 PM

Change #1247118 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Refactor ParserCache-related tests with a common cache creation

https://gerrit.wikimedia.org/r/1247118

gerritbot added a comment.Mar 10 2026, 12:18 AM

Change #1244744 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Refactor FlaggedRevsParserCache to get them through a factory

https://gerrit.wikimedia.org/r/1244744

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.19; 2026-03-10); removed: MW-1.46-notes (1.46.0-wmf.18; 2026-03-03).Mar 10 2026, 1:00 AM
Dreamy_Jazz subscribed.Mar 10 2026, 2:09 PM

This ticket seems to have caused T419539: Changes in FlaggedRevs seem to be causing CI failures for CheckUser, blocking CheckUser CI

pmiazga mentioned this in T420024: [SPIKE] Attribution API Citation count followup: Citation # in Flagged Revs wikis.Mar 13 2026, 4:42 PM
gerritbot added a comment.Mar 16 2026, 2:59 PM

Change #1253521 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/FlaggedRevs@master] Move postprocessing of flaggedrev views inside FlaggablePageView, take 2

https://gerrit.wikimedia.org/r/1253521

gerritbot added a comment.Mar 16 2026, 4:22 PM

Change #1253521 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Move postprocessing of flaggedrev views inside FlaggablePageView, take 2

https://gerrit.wikimedia.org/r/1253521

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17); removed: MW-1.46-notes (1.46.0-wmf.19; 2026-03-10).Mar 16 2026, 5:00 PM
gerritbot added a comment.Mar 17 2026, 12:36 AM

Change #1239379 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Add postprocessing cache for FlaggedRevs

https://gerrit.wikimedia.org/r/1239379

ihurbain closed this task as Resolved.Mar 26 2026, 8:26 AM

Parsoid FlaggedRevs postprocessing cache has been running for a week, so let's consider this resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits