LoadBalancerTest.php:630)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	A_smart_kitten
	Jan 13 2026, 11:51 AM

Project Tags

Referenced Files

None

Subscribers

Description

Cross-reference https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1180659 (Add #[\NoDiscard] to functions that return ScopedCallback; 83171021b16f)

mediawiki/core (84b44c1d7dbf) locally, running PHP 8.5
composer phpunit:entrypoint -- --filter LoadBalancerTest

1) LoadBalancerTest::testDBConnRefReadsMasterAndReplicaRoles
The return value of method Wikimedia\Rdbms\DBConnRef::getScopedLockAndFlush() should either be used or intentionally ignored by casting it as (void)

/[...]/mediawiki/core/tests/phpunit/includes/DB/LoadBalancerTest.php:630

(note: not yet seen in WMF experimental CI due to the order in which it runs MediaWiki's PHPUnit tests, but it presumably would be seen there at some point)

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Fix PHP 8.5 warning for unused return value in LoadBalancerTest	Shivaansh Singh	mediawiki/core	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: T411814: Make PHP 8.5 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI
Mentioned Here: rMW83171021b16f: Add #[\NoDiscard] to functions that return ScopedCallback
rMW84b44c1d7dbf: Special:EditWatchlist: Use primary DB during POST requests

Event Timeline

A_smart_kitten created this task.Jan 13 2026, 11:51 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 13 2026, 11:51 AM

A_smart_kitten moved this task from Backlog to MediaWiki core on the PHP 8.5 support board.Jan 13 2026, 11:51 AM

A_smart_kitten mentioned this in T411814: Make PHP 8.5 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI.Jan 13 2026, 1:37 PM

ShivaanshSingh subscribed.Jan 13 2026, 1:42 PM

Change #1226252 had a related patch set uploaded (by Bartosz Dziewoński; author: Shivaansh Singh):

[mediawiki/core@master] Fix PHP 8.5 warning for unused return value in LoadBalancerTest

https://gerrit.wikimedia.org/r/1226252

gerritbot added a project: Patch-For-Review.Jan 19 2026, 4:34 PM

Change #1226252 merged by jenkins-bot:

[mediawiki/core@master] Fix PHP 8.5 warning for unused return value in LoadBalancerTest

https://gerrit.wikimedia.org/r/1226252

Thanks for the patch @ShivaanshSingh!

Maintenance_bot removed a project: Patch-For-Review.Jan 19 2026, 5:31 PM

ShivaanshSingh added a project: RoadToWiki.Jan 23 2026, 2:30 PM

Akaza24 moved this task from Incoming to Completed on the RoadToWiki board.Jan 28 2026, 4:40 PM

The return value of method Wikimedia\Rdbms\DBConnRef::getScopedLockAndFlush() should either be used or intentionally ignored by casting it as (void) (from tests/phpunit/includes/DB/LoadBalancerTest.php:630)Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

The return value of method Wikimedia\Rdbms\DBConnRef::getScopedLockAndFlush() should either be used or intentionally ignored by casting it as (void) (from tests/phpunit/includes/DB/LoadBalancerTest.php:630)
Closed, ResolvedPublic
Actions