Page MenuHomePhabricator

growthexperiments_mentor_mentee.gemm_mentee_is_active is not present on some Wikipedias
Closed, ResolvedPublic

Description

In T318518, we added the gemm_mentee_is_active column to growthexperiments_mentor_mentee x1 table. Unfortunately, it seems like it is not present on all wikis:

[urbanecm@deploy2002 ~]$ kubectl logs job/growthexperiments-updateisactiveflagformentees-29470182
Defaulted container "mediawiki-main-app" out of: mediawiki-main-app, mediawiki-main-tls-proxy, mediawiki-main-rsyslog
extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php: Start run
extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php: Running on growthexperiments.dblist
extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php: Running on growthexperiments.dblist
pcmwiki Wikimedia\Rdbms\DBQueryError from line 1227 of /srv/mediawiki/php-1.46.0-wmf.10/includes/libs/Rdbms/Database/Database.php: Error 1054: Unknown column 'gemm_mentee_is_active' in 'WHERE'
pcmwiki Function: GrowthExperiments\Maintenance\UpdateIsActiveFlagForMentees::execute
pcmwiki Query: SELECT  gemm_mentee_id AS `value`  FROM `growthexperiments_mentor_mentee`    WHERE gemm_mentor_role = 'primary' AND gemm_mentee_is_active = 1  
pcmwiki 
pcmwiki #0 /srv/mediawiki/php-1.46.0-wmf.10/includes/libs/Rdbms/Database/Database.php(1211): Wikimedia\Rdbms\Database->getQueryException('Unknown column ...', 1054, 'SELECT  gemm_me...', 'GrowthExperimen...')
pcmwiki #1 /srv/mediawiki/php-1.46.0-wmf.10/includes/libs/Rdbms/Database/Database.php(1185): Wikimedia\Rdbms\Database->getQueryExceptionAndLog('Unknown column ...', 1054, 'SELECT  gemm_me...', 'GrowthExperimen...')
pcmwiki #2 /srv/mediawiki/php-1.46.0-wmf.10/includes/libs/Rdbms/Database/Database.php(642): Wikimedia\Rdbms\Database->reportQueryError('Unknown column ...', 1054, 'SELECT  gemm_me...', 'GrowthExperimen...', false)
pcmwiki #3 /srv/mediawiki/php-1.46.0-wmf.10/includes/libs/Rdbms/Database/Database.php(1365): Wikimedia\Rdbms\Database->query(Object(Wikimedia\Rdbms\Query), 'GrowthExperimen...')
pcmwiki #4 /srv/mediawiki/php-1.46.0-wmf.10/includes/libs/Rdbms/Database/Database.php(1338): Wikimedia\Rdbms\Database->select(Array, Array, Array, 'GrowthExperimen...', Array, Array)
pcmwiki #5 /srv/mediawiki/php-1.46.0-wmf.10/includes/libs/Rdbms/Database/DBConnRef.php(129): Wikimedia\Rdbms\Database->selectFieldValues(Array, 'gemm_mentee_id', Array, 'GrowthExperimen...', Array, Array)
pcmwiki #6 /srv/mediawiki/php-1.46.0-wmf.10/includes/libs/Rdbms/Database/DBConnRef.php(378): Wikimedia\Rdbms\DBConnRef->__call('selectFieldValu...', Array)
pcmwiki #7 /srv/mediawiki/php-1.46.0-wmf.10/includes/libs/Rdbms/QueryBuilder/SelectQueryBuilder.php(797): Wikimedia\Rdbms\DBConnRef->selectFieldValues(Array, 'gemm_mentee_id', Array, 'GrowthExperimen...', Array, Array)
pcmwiki #8 /srv/mediawiki/php-1.46.0-wmf.10/extensions/GrowthExperiments/maintenance/updateIsActiveFlagForMentees.php(70): Wikimedia\Rdbms\SelectQueryBuilder->fetchFieldValues()
pcmwiki #9 /srv/mediawiki/php-1.46.0-wmf.10/maintenance/includes/MaintenanceRunner.php(696): GrowthExperiments\Maintenance\UpdateIsActiveFlagForMentees->execute()
pcmwiki #10 /srv/mediawiki/php-1.46.0-wmf.10/maintenance/run.php(53): MediaWiki\Maintenance\MaintenanceRunner->run()
pcmwiki #11 /srv/mediawiki/multiversion/MWScript.php(219): require_once('/srv/mediawiki/...')
pcmwiki #12 {main}
[urbanecm@deploy2002 ~]$ sql pcmwiki --cluster=extension1
wikiadmin2023@10.192.32.153(pcmwiki)> describe growthexperiments_mentor_mentee;
+------------------+------------------+------+-----+---------+-------+
| Field            | Type             | Null | Key | Default | Extra |
+------------------+------------------+------+-----+---------+-------+
| gemm_mentee_id   | int(10) unsigned | NO   | PRI | NULL    |       |
| gemm_mentor_role | varbinary(255)   | NO   | PRI | NULL    |       |
| gemm_mentor_id   | int(10) unsigned | NO   | MUL | NULL    |       |
+------------------+------------------+------+-----+---------+-------+
3 rows in set (0.004 sec)

wikiadmin2023@10.192.32.153(pcmwiki)> Bye
[urbanecm@deploy2002 ~]$

This is making the updateisactiveflagformentees script unable to execute on some wikis (at least pcmwiki).

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

DBA: I'll need some support on this one. The column should exist on wikipedia.dblist. Providing growthexperiments.dblist in T318518 was an error on my end (since T364308, the relevant DB tables is created on all new wikis).

Wikis without the column and wikis without the table (which per our IRC chat, it looks expected):

1[15:11:38] marostegui@cumin1003:~/git/mediawiki-config/dblists$ for i in $(grep -v '^#' wikipedia.dblist); do sudo db-mysql db2191 "$i" -e "SHOW CREATE TABLE growthexperiments_mentor_mentee\G" | grep -q gemm_mentee_is_active || echo "$i"; done
2aawiki
3blkwiki
4chowiki
5guwwiki
6howiki
7hzwiki
8iiwiki
9kcgwiki
10kjwiki
11--------------
12SHOW CREATE TABLE growthexperiments_mentor_mentee
13--------------
14
15ERROR 1146 (42S02) at line 1: Table 'kncwiki.growthexperiments_mentor_mentee' doesn't exist
16kncwiki
17krwiki
18lrcwiki
19mhwiki
20muswiki
21ngwiki
22--------------
23SHOW CREATE TABLE growthexperiments_mentor_mentee
24--------------
25
26ERROR 1146 (42S02) at line 1: Table 'nupwiki.growthexperiments_mentor_mentee' doesn't exist
27nupwiki
28pcmwiki
29--------------
30SHOW CREATE TABLE growthexperiments_mentor_mentee
31--------------
32
33ERROR 1146 (42S02) at line 1: Table 'rkiwiki.growthexperiments_mentor_mentee' doesn't exist
34rkiwiki
35--------------
36SHOW CREATE TABLE growthexperiments_mentor_mentee
37--------------
38
39ERROR 1146 (42S02) at line 1: Table 'sylwiki.growthexperiments_mentor_mentee' doesn't exist
40sylwiki
41tenwiki
42--------------
43SHOW CREATE TABLE growthexperiments_mentor_mentee
44--------------
45
46ERROR 1146 (42S02) at line 1: Table 'tigwiki.growthexperiments_mentor_mentee' doesn't exist
47tigwiki
48--------------
49SHOW CREATE TABLE growthexperiments_mentor_mentee
50--------------
51
52ERROR 1146 (42S02) at line 1: Table 'tokwiki.growthexperiments_mentor_mentee' doesn't exist
53tokwiki

Mentioned in SAL (#wikimedia-operations) [2026-01-13T15:16:49Z] <marostegui> Deploy schema change on x1 master to fix T414474

Marostegui claimed this task.

Deployed, only wikis where the table isn't present are now showing up:
{P87471#351924}

Thank you so much @Marostegui! This has been very helpful.