Page MenuHomePhabricator

[MEX][QC] Constraint violations popover is invisible on musical notation snaks
Closed, ResolvedPublic

Assigned To
Authored By
Lucas_Werkmeister_WMDE
Jan 13 2026, 4:45 PM
Referenced Files
F71525510: image.png
Jan 14 2026, 1:19 PM
F71520083: image.png
Jan 13 2026, 4:58 PM
F71520081: image.png
Jan 13 2026, 4:58 PM
F71519987: image.png
Jan 13 2026, 4:45 PM
F71519963: image.png
Jan 13 2026, 4:45 PM

Description

If a musical notation statement has a constraint violation, the popover with the details is invisible in MEX / wbui2025:

image.png (121×369 px, 11 KB)

This is due to the mask-image on the .wikibase-wbui2025-snak-value (which is used to implement the scroll-indicating fade, see T412128), which masks the whole popover.

image.png (346×340 px, 32 KB)

We need to figure out how to fix this. (Note that according to T412128 the fade is optional, so one option might be to remove the mask-image if we can’t find a better solution.)

Event Timeline

Suggestion: let’s disable the fade when a popover is open. So if you tap the indicator icon while it’s still in the faded area, it potentially goes from this:

image.png (283×356 px, 31 KB)

to this:
image.png (283×356 px, 22 KB)

@Alice.moutinho does that sound okay? Or should we look for another solution?

(Note: the score image is cut off by LilyPond itself, that’s why it doesn’t look faded even in the first screenshot. If I wasn’t scrolled near the right edge then you’d see the fade on the score, but you wouldn’t see the icon.)

Change #1226848 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove fade-out gradient when popover is open

https://gerrit.wikimedia.org/r/1226848

I think this is ready for peer review, though with the caveat that Alice might ask for a different solution when she’s back :)

The alternative solution mentioned in the commit message looks like this:

diff --git c/repo/resources/wikibase.wbui2025/components/indicatorPopover.vue w/repo/resources/wikibase.wbui2025/components/indicatorPopover.vue
index b49c3940db..e4b3ef41ed 100644
--- c/repo/resources/wikibase.wbui2025/components/indicatorPopover.vue
+++ w/repo/resources/wikibase.wbui2025/components/indicatorPopover.vue
@@ -5,7 +5,6 @@
 		:use-close-button="true"
 		:use-primary-action="false"
 		:use-default-action="false"
-		:render-in-place="true"
 		placement="bottom-end"
 		@update:open="$emit( 'close' )"
 	>

image.png (296×365 px, 35 KB)

Hi @Lucas_Werkmeister_WMDE , this is such an edge case that honestly i am fine with the solution! When there is an error being clicked, it is more important that people read the error... and this happens. Thank you for figuring it out

Change #1226848 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove fade-out gradient when popover is open

https://gerrit.wikimedia.org/r/1226848