Page MenuHomePhabricator
Create Task
Maniphest T414581

Special:EditWatchlist: modified popup when no change will be made
Closed, ResolvedPublic
Actions

Assigned To
Samwilson
Authored By
Cparle
Jan 14 2026, 2:05 PM
Project Tags
Referenced Files
F71820278: 2026-02-11_08-58-20.png
Feb 11 2026, 5:16 PM
F71820209: 2026-02-11_08-55-26.png
Feb 11 2026, 5:16 PM
F71820172: 2026-02-11_08-53-45.png
Feb 11 2026, 5:16 PM
F71820509: 2026-02-11_09-12-19.png
Feb 11 2026, 5:16 PM
F71819941: 2026-02-11_08-40-29.png
Feb 11 2026, 5:16 PM
F71632283: 2026-01-30_14-41-42.png
Jan 30 2026, 10:55 PM
F71632251: 2026-01-30_14-37-24.png
Jan 30 2026, 10:55 PM
F71632248: 2026-01-30_14-36-34.png
Jan 30 2026, 10:55 PM
View All 19 Files
Subscribers
Aklapper
Cparle
GMikesell-WMF
JSengupta-WMF
Samwilson

Description

On Special:EditWatchlist:

  1. If a user selects 1+ watched items and clicks "assign labels" but has no watchlist labels defined
    • the modal header should say "Unable to assign labels"
    • the modal text should say something like "You cannot assign labels to these watched items, because you have no labels defined. Click here to create watchlist labels."
    • the modal should contain a single button that says "Ok"
  2. If a user selects 1+ watched items and clicks "remove labels" but none of the watched items have labels assigned to them
    • the modal header should say "Unable to remove labels"
    • the modal text should say something like "There are no labels assigned to the items you have selected."
    • the modal should contain a single button that says "Ok"

(designs here)

Derived Requirement

Ensure that on Special:EditWatchlist, when a user attempts to assign or remove labels but no change can be made, an informative modal is displayed that clearly explains why the action cannot proceed and provides a single acknowledgment option.

Test Steps

Test Case 1: Ensure informative modal is shown when assigning labels with no labels defined

  1. Navigate to Special:EditWatchlist.
  2. Select one or more watched items.
  3. Ensure no watchlist labels are defined for the user.
  4. Click the "assign labels" action.
  5. Observe the modal dialog.
  6. ✅❓❌⬜ AC1: A modal is displayed with the header "Unable to assign labels", explanatory text indicating that no labels are defined and linking to label creation, and a single "Ok" button.

Test Case 2: Ensure informative modal is shown when removing labels from items with no labels

  1. Navigate to Special:EditWatchlist.
  2. Select one or more watched items.
  3. Ensure the selected items have no labels assigned.
  4. Click the "remove labels" action.
  5. Observe the modal dialog.
  6. ✅❓❌⬜ AC2: A modal is displayed with the header "Unable to remove labels", explanatory text indicating that no labels are assigned to the selected items, and a single "Ok" button.

QA Results -Beta

ACStatusDetails
1✅T414581#11608375
2✅T414581#11608375

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Special:EditWatchlist: Improve labels dialog messagesSamwilsonmediawiki/coremaster+10 -5
Special:EditWatchlist: Fix label dialog header messagesSamwilsonmediawiki/coremaster+20 -6
Special:EditWatchlist: Enable buttons and add more messagesSamwilsonmediawiki/coremaster+36 -16
Customize query in gerrit

Related Objects

Event Timeline

Cparle created this task.Jan 14 2026, 2:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 14 2026, 2:05 PM
Cparle renamed this task from On Special:EditWatchlist disable buttons unless they can actually do something to Special:EditWatchlist: modified popup text/buttons when no change will be made.Jan 14 2026, 2:21 PM
Cparle updated the task description. (Show Details)
Cparle updated the task description. (Show Details)
Cparle renamed this task from Special:EditWatchlist: modified popup text/buttons when no change will be made to Special:EditWatchlist: modified popup when no change will be made.Jan 14 2026, 2:27 PM
Cparle updated the task description. (Show Details)
Prashant32194 subscribed.Jan 14 2026, 6:06 PM
Samwilson subscribed.Jan 15 2026, 5:49 AM

Should the 'Remove pages' (formerly 'Unwatch') button also never be disabled? And have a warning message that the others?

Samwilson changed the task status from Open to In Progress.Jan 15 2026, 6:06 AM
Samwilson claimed this task.
Samwilson moved this task from Ready for Dev to In Development on the Community-Tech (Fox Squad) board.
Cparle added a subscriber: JSengupta-WMF.Jan 15 2026, 10:17 AM

@JSengupta-WMF ☝️ ?

JSengupta-WMF added a comment.Jan 15 2026, 10:55 AM

✅ 🙏🏼

Samwilson added a comment.Jan 19 2026, 6:43 AM

@JSengupta-WMF Is it still the case that we should avoids link text that says "click here"? I know it used to be important, e.g. https://www.w3.org/TR/WCAG20-TECHS/F84.html

JSengupta-WMF added a comment.Jan 19 2026, 9:03 AM

Ah yes I overlooked it sorry. It should say

You cannot assign labels to these watched items, because you have no labels defined. > This is a message

Create a watchlist label > This is a link

Prashant32194 unsubscribed.Jan 19 2026, 9:16 AM
Samwilson moved this task from Backlog to Assign labels on Special:EditWatchlist on the Watchlist-Labels board.Jan 27 2026, 9:06 AM
gerritbot added a comment.Jan 28 2026, 3:45 AM

Change #1228717 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] Special:EditWatchlist: Enable buttons and add more messages

https://gerrit.wikimedia.org/r/1228717

gerritbot added a project: Patch-For-Review.Jan 28 2026, 3:45 AM
Samwilson moved this task from In Development to Feedback and Review on the Community-Tech (Fox Squad) board.Jan 28 2026, 5:19 AM
Cparle mentioned this in T411760: Handle submission of "remove labels" modal.Jan 28 2026, 12:12 PM
gerritbot added a comment.Jan 28 2026, 12:54 PM

Change #1228717 merged by jenkins-bot:

[mediawiki/core@master] Special:EditWatchlist: Enable buttons and add more messages

https://gerrit.wikimedia.org/r/1228717

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.14; 2026-02-03).Jan 28 2026, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 28 2026, 1:32 PM
Cparle moved this task from Feedback and Review to QA on the Community-Tech (Fox Squad) board.Jan 28 2026, 4:57 PM
GMikesell-WMF updated Other Assignee, added: GMikesell-WMF.Jan 28 2026, 8:28 PM
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF subscribed.Jan 29 2026, 12:34 AM

@Samwilson Can you please review AC1? The screenshots don't match the Figma designs. Also, I am able to not select labels when clicking on a page and still click Assign. Thanks!

Test Result - Beta

Status: ❌ FAIL
Environment: Beta
OS: macOS Tahoe 26.2
Browser: Chrome 143
Device: MBA
Emulated Device: NA

Test Artifact(s): Screenshots of modal dialogs on Special:EditWatchlist

Test Steps

Test Case 1: Ensure informative modal is shown when assigning labels with no labels defined

  1. Navigate to Special:EditWatchlist.
  2. Select one or more watched items.
  3. Ensure no watchlist labels are defined for the user.
  4. Click the "assign labels" action.
  5. Observe the modal dialog.
  6. ❌ AC1: A modal is displayed with the header "Unable to assign labels", explanatory text indicating that no labels are defined and linking to label creation, and a single "Ok" button.
Figma
2026-01-28_12-33-50.png (775×519 px, 71 KB)
Assign: No Page selectedRemove: No Page selectedAssign: Pages selected w/no Labels existRemove: Pages selected w/no Labels exist
2026-01-28_12-35-09.png (1,208×982 px, 168 KB)
2026-01-28_12-35-16.png (1,213×974 px, 167 KB)
2026-01-28_12-36-23.png (1,208×828 px, 151 KB)
2026-01-28_12-36-31.png (1,210×858 px, 154 KB)

Will there be a message if you don't select any labels and still click Assign?

Labels exist but do not select any w/multiple pages selected

Test Case 2: Ensure informative modal is shown when removing labels from items with no labels

  1. Navigate to Special:EditWatchlist.
  2. Select one or more watched items.
  3. Ensure the selected items have no labels assigned.
  4. Click the "remove labels" action.
  5. Observe the modal dialog.
  6. ❌AC2: A modal is displayed with the header "Unable to remove labels", explanatory text indicating that no labels are assigned to the selected items, and a single "Ok" button.

See AC1

GMikesell-WMF updated the task description. (Show Details)Jan 29 2026, 12:35 AM
GMikesell-WMF moved this task from QA to In Development on the Community-Tech (Fox Squad) board.
Samwilson added a comment.Jan 29 2026, 1:43 AM

❌ AC1: A modal is displayed with the header "Unable to assign labels", explanatory text indicating that no labels are defined and linking to label creation, and a single "Ok" button.
❌AC2: A modal is displayed with the header "Unable to remove labels", explanatory text indicating that no labels are assigned to the selected items, and a single "Ok" button.

Just to confirm: it's only the header text of the dialog that is wrong in these two cases isn't it? I'll update that now.

Will there be a message if you don't select any labels and still click Assign?

No, that will just submit the page and no changes will be made. I think that complies with the design.

gerritbot added a comment.Jan 29 2026, 2:00 AM

Change #1234568 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] Special:EditWatchlist: Fix label dialog header messages

https://gerrit.wikimedia.org/r/1234568

gerritbot added a project: Patch-For-Review.Jan 29 2026, 2:00 AM
Samwilson moved this task from In Development to Feedback and Review on the Community-Tech (Fox Squad) board.Jan 29 2026, 3:14 AM
Cparle moved this task from Feedback and Review to QA on the Community-Tech (Fox Squad) board.Jan 30 2026, 4:01 PM
gerritbot added a comment.Jan 30 2026, 4:29 PM

Change #1234568 merged by jenkins-bot:

[mediawiki/core@master] Special:EditWatchlist: Fix label dialog header messages

https://gerrit.wikimedia.org/r/1234568

Maintenance_bot removed a project: Patch-For-Review.Jan 30 2026, 4:33 PM
GMikesell-WMF added a comment.Jan 30 2026, 10:55 PM
In T414581#11564631, @Samwilson wrote:

❌ AC1: A modal is displayed with the header "Unable to assign labels", explanatory text indicating that no labels are defined and linking to label creation, and a single "Ok" button.
❌AC2: A modal is displayed with the header "Unable to remove labels", explanatory text indicating that no labels are assigned to the selected items, and a single "Ok" button.

Just to confirm: it's only the header text of the dialog that is wrong in these two cases isn't it? I'll update that now.

Will there be a message if you don't select any labels and still click Assign?

No, that will just submit the page and no changes will be made. I think that complies with the design.

@Samwilson

  • Headers and text in box don't match Figma
FigmaPage selected but with no labels associated & clicked "Remove labels"
2026-01-30_14-35-08.png (568×204 px, 19 KB)
2026-01-30_14-27-10.png (1,158×775 px, 136 KB)
FigmaNo Page selected & clicked "Remove labels"
2026-01-30_14-35-39.png (554×184 px, 20 KB)
2026-01-30_14-33-01.png (1,194×890 px, 153 KB)
FigmaNo pages selected & clicked "Assign labels"
2026-01-30_14-36-54.png (578×190 px, 22 KB)
2026-01-30_14-36-34.png (1,188×833 px, 151 KB)
FigmaNo Page selected & clicked "Remove pages"
2026-01-30_14-37-24.png (565×195 px, 22 KB)
2026-01-30_14-41-42.png (1,177×761 px, 143 KB)
GMikesell-WMF updated the task description. (Show Details)Jan 30 2026, 10:56 PM
GMikesell-WMF moved this task from QA to In Development on the Community-Tech (Fox Squad) board.
Samwilson added a comment.Feb 3 2026, 7:01 AM

Headers and text in box don't match Figma

@GMikesell-WMF I think you were testing before the latest changes had propagated to Beta, sorry! At least some of the dialog headings should be correct now.

The deviations from Figma are as follows:

Page selected but with no labels associated & clicked "Remove labels"

  • Figma: Unable to remove label / There are no labels assigned to this page.
  • MediaWiki: Unable to remove labels / There are no labels assigned to the pages that you have selected.

I've made a fix for the plural pages here, so it is correct when there's a single page selected.

No Page selected & clicked "Remove labels"

  • Figma: Unable to remove label / Please select label(s) you want to remove.
  • MediaWiki: Unable to remove labels / Please select the pages from which you would like to remove labels.

I don't think the Figma text makes sense here.

No pages selected & clicked "Assign labels"

  • Figma: Unable to assign label / Please select title(s) you want to assign this label to.
  • MediaWiki: Unable to assign labels / Please select the pages to which you would like to assign labels.

We're refering to "pages" or "items" on a watchlist now, not "titles" (other than when raw editing).

No Page selected & clicked "Remove pages"

  • Figma: Unable to remove title / Please select title(s) you would like to remove.
  • MediaWiki: Remove pages / Please select the pages to remove from your watchlist.

Again this should refer to "pages", and I've made a fix for the header here and added the "would like to remove" bit.

gerritbot added a comment.Feb 3 2026, 7:03 AM

Change #1236112 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] Special:EditWatchlist: Improve labels dialog messages

https://gerrit.wikimedia.org/r/1236112

gerritbot added a project: Patch-For-Review.Feb 3 2026, 7:03 AM
Samwilson moved this task from In Development to Feedback and Review on the Community-Tech (Fox Squad) board.Feb 3 2026, 8:30 AM
gerritbot added a comment.Feb 11 2026, 7:02 AM

Change #1236112 merged by jenkins-bot:

[mediawiki/core@master] Special:EditWatchlist: Improve labels dialog messages

https://gerrit.wikimedia.org/r/1236112

Maintenance_bot removed a project: Patch-For-Review.Feb 11 2026, 7:30 AM
ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.16; 2026-02-17); removed: MW-1.46-notes (1.46.0-wmf.14; 2026-02-03).Feb 11 2026, 8:00 AM
Samwilson moved this task from Feedback and Review to QA on the Community-Tech (Fox Squad) board.Feb 11 2026, 8:33 AM
GMikesell-WMF added a comment.Feb 11 2026, 5:16 PM

@Samwilson Thanks for the update! Screenshots are now updated. I will mark this as Resolved. Thanks for all your work!

Page selected but with no labels associated & clicked "Remove labels"

Figma: Unable to remove label / There are no labels assigned to this page.
MediaWiki: Unable to remove labels / There are no labels assigned to the pages that you have selected.

I've made a fix for the plural pages here, so it is correct when there's a single page selected.

✅ Page selected but with no labels associated & clicked "Remove labels"

SinglePlural
2026-02-11_08-40-29.png (1,463×742 px, 152 KB)
2026-02-11_09-12-19.png (1,518×808 px, 162 KB)

No Page selected & clicked "Remove labels"

Figma: Unable to remove label / Please select label(s) you want to remove.
MediaWiki: Unable to remove labels / Please select the pages from which you would like to remove labels.

I don't think the Figma text makes sense here.

✅

No Page selected & clicked "Remove labels"
2026-02-11_08-53-45.png (1,459×876 px, 165 KB)

No pages selected & clicked "Assign labels"

Figma: Unable to assign label / Please select title(s) you want to assign this label to.
MediaWiki: Unable to assign labels / Please select the pages to which you would like to assign labels.

We're refering to "pages" or "items" on a watchlist now, not "titles" (other than when raw editing).

✅

No pages selected & clicked "Assign labels"
2026-02-11_08-55-26.png (1,422×830 px, 158 KB)

No Page selected & clicked "Remove pages"

Figma: Unable to remove title / Please select title(s) you would like to remove.
MediaWiki: Remove pages / Please select the pages to remove from your watchlist.

Again this should refer to "pages", and I've made a fix for the header here and added the "would like to remove" bit.

✅

No Page selected & clicked "Remove pages"
2026-02-11_08-58-20.png (1,443×950 px, 176 KB)
GMikesell-WMF closed this task as Resolved.Feb 11 2026, 5:17 PM
GMikesell-WMF updated Other Assignee, removed: GMikesell-WMF.
GMikesell-WMF updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits