Page MenuHomePhabricator

[regression, 1.46.0-wmf.11] ProofreadPage navigation tabs on Page pages are missing in Vector, Monobook, CologneBlue and Modern skins
Closed, ResolvedPublic5 Estimated Story PointsPRODUCTION ERROR

Description

Error

First reported at https://www.mediawiki.org/w/index.php?title=Project%3AVillage_Pump#c-EncycloPetey-20260114194200-Wikisource_navigation_broken_in_Page_namespace

On a page like https://en.wikisource.org/wiki/Page:Haunted_Man_(Dickens,_1848).pdf/121
there's no "Image" tab at the top of the page linking to the source image (in this case, [https://upload.wikimedia.org/wikipedia/commons/thumb/c/cf/Haunted_Man_%28Dickens%2C_1848%29.pdf/page121-718px-Haunted_Man_%28Dickens%2C_1848%29.pdf.jpg this one]), and also no "Index" linking to the index ([[wikisource:Index:Haunted_Man_(Dickens,_1848).pdf|this one]]), nor "Forwards" and "Backwards" tabs, but the "Page" and "Discussion" tabs are there.

I note that I see all four links to Forward, Backwards, Image, and Index [https://en.wikisource.org/wiki/Page:Haunted_Man_(Dickens,_1848).pdf/121?useskin=minerva in Minerva], but only Image [https://en.wikisource.org/wiki/Page:Haunted_Man_(Dickens,_1848).pdf/121?useskin=vector-2022 in Vector 2022], and none in the old, less-supported skins: [https://en.wikisource.org/wiki/Page:Haunted_Man_(Dickens,_1848).pdf/121?useskin=vector in Vector] or [https://en.wikisource.org/wiki/Page:Haunted_Man_(Dickens,_1848).pdf/121?useskin=monobook in Monobook].

Impact

Loss of functionality.

Notes

I know the Reading teams were working on these tabs this week.

Event Timeline

Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF raised the priority of this task from Medium to Unbreak Now!.Jan 14 2026, 8:41 PM
Jdforrester-WMF added a subscriber: Jdlrobson-WMF.

Train blocker -> UBN! as a status.

I imagine this is related to T412238: Deprecate support for namespaces key in SkinTemplateNavigation::Universal.

Jdforrester-WMF renamed this task from [Regression, 1.46.0-wmf.11] ProofreadPage navigation tabs on Page pages are missing in some skins to [regression, 1.46.0-wmf.11] ProofreadPage navigation tabs on Page pages are missing in some skins.Jan 14 2026, 8:43 PM

but only Image [https://en.wikisource.org/wiki/Page:Haunted_Man_(Dickens,_1848).pdf/121?useskin=vector-2022 in Vector 2022],

They're all present. The other three, forward, backwards and index links are icons. I think that's likely why you didn't notice them.

I'll take a look and work out best course of action here.

Jdlrobson-WMF renamed this task from [regression, 1.46.0-wmf.11] ProofreadPage navigation tabs on Page pages are missing in some skins to [regression, 1.46.0-wmf.11] ProofreadPage navigation tabs on Page pages are missing in Vector, Monobook, CologneBlue and Modern skins.Jan 14 2026, 9:10 PM

Okay, so this patch likely landed earlier than it should have. Seems like we have a chicken/egg problem. I can revert it in my backport window later and we can reapply it at a later date.

Monobook has already been patched in next train, and Vector has an open patch. We can reapply the patch when it's landed.

For future, I assume the UBN status is only for Vector and Monobook (CologneBlue and Modern seem like lower concerns - I hope we wouldn't block trains for those skins)?

Change #1226941 had a related patch set uploaded (by Jforrester; author: Jdlrobson):

[mediawiki/extensions/ProofreadPage@master] Revert "Do not use deprecated menu"

https://gerrit.wikimedia.org/r/1226941

Change #1226945 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ProofreadPage@wmf/1.46.0-wmf.11] Revert "Do not use deprecated menu"

https://gerrit.wikimedia.org/r/1226945

Change #1226941 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Revert "Do not use deprecated menu"

https://gerrit.wikimedia.org/r/1226941

Change #1226945 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@wmf/1.46.0-wmf.11] Revert "Do not use deprecated menu"

https://gerrit.wikimedia.org/r/1226945

Mentioned in SAL (#wikimedia-operations) [2026-01-14T21:56:47Z] <jhuneidi@deploy2002> Started scap sync-world: Backport for [[gerrit:1226945|Revert "Do not use deprecated menu" (T414630)]]

Mentioned in SAL (#wikimedia-operations) [2026-01-14T21:58:59Z] <jhuneidi@deploy2002> jhuneidi, jdlrobson: Backport for [[gerrit:1226945|Revert "Do not use deprecated menu" (T414630)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-01-14T22:06:03Z] <jhuneidi@deploy2002> Finished scap sync-world: Backport for [[gerrit:1226945|Revert "Do not use deprecated menu" (T414630)]] (duration: 09m 16s)