Page MenuHomePhabricator

fluidsynth 2.5.2 throws illegal option error when executing midi conversion
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Upload a midi to a wiki with transcoding
  • this wiki runs on macos with a homebrew install of fluidsynth 2.5.5
  • /opt/homebrew//bin/fluidsynth -T wav /opt/homebrew/share/fluid-synth/sf2/VintageDreamsWaves-v2.sf2 input.mid -F output.wav

What happens?:
When run from shellbox wrapper, i see the command throw error: '-F' is an illegal option at this place, only -b option is allowed here.

What should have happened instead?:
Command should be able to run.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
The argument order has been like this for a long while (over 8 years):

Usage:
    fluidsynth [options] [soundfonts] [midifiles]

https://github.com/FluidSynth/fluidsynth/blame/26d53b2d7a06ebb17788c84af3c9564a6e0daa70/src/fluidsynth.c#L1237

Event Timeline

Change #1226966 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] fluidsynth: use correct parameter order as documented

https://gerrit.wikimedia.org/r/1226966

Not entirely sure why this was not noticed before. Did fluidsynth become more strict ?

@bvibber just wondering what happens for you with your version of fluid synth ? For me this failed hard on macOS, but it's always been this order in our code, so I presume they changed this in a specific version of fluidsynth, but I can't find the change in their repo. It's also possible it's just their macOS specific parser is more strict.

Change #1226966 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] fluidsynth: use correct parameter order as documented

https://gerrit.wikimedia.org/r/1226966