Page MenuHomePhabricator

TextMatchEditCheck doesn't reflect ignoreLeadSection on individual match configurations
Closed, ResolvedPublic

Description

I set ignoreLeadSection to true in this match configuration on this patchdemo. I found that the lead section was still included. I then added the same setting on the whole check, and found that the lead section was ignored by the check as expected.

Impact

This ticket is blocking the parent task, deploying British English suggestions/checks to enwiki

Done

  • TextMatchEditCheck reflects ignoreLeadSection (on main branch)

Timeline

We're consulting with community about word lists, so this isn't on the critical path but it would be preferable to handle it beforehand to avoid having to explain this difference to users.

Event Timeline

Change #1227362 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] TextMatchEditCheck: respect matchItem config for valid sections

https://gerrit.wikimedia.org/r/1227362

Change #1227362 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] TextMatchEditCheck: respect matchItem config for valid sections

https://gerrit.wikimedia.org/r/1227362

Ryasmeen edited projects, added Verified; removed Editing QA.