Page MenuHomePhabricator

MobileFrontend + Parsoid has different collapsible-section HTML on en.wp main page
Open, MediumPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What should have happened instead?:
Mobile + Parsoid should match the other renderings

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
I put this together the way I did because I wanted to leave the comma out of the heading. I'm slightly puzzled that MF+Parsoid is ending up with an extra div there:

image.png (78×608 px, 14 KB)

That is present in none of legacy and desktop Parsoid renderings, example from desktop Parsoid:

image.png (69×590 px, 10 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1227820 had a related patch set uploaded (by Rehan_khan_78; author: Rehan_khan_78):

[mediawiki/extensions/MobileFrontend@master] MobileFrontend: keep punctuation inline in headings for Parsoid

https://gerrit.wikimedia.org/r/1227820

Jdlrobson-WMF subscribed.

The issue is in the call to $parserOptions->setCollapsibleSections();. That seems to incorrectly wrap the comma in a DIV. The logic should be modified to only apply to headings that are direct descendents of .mw-parser-output

Change #1227852 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Only wrap elements which are in sections

https://gerrit.wikimedia.org/r/1227852

Change #1227820 had a related patch set uploaded (by Rehan_khan_78; author: Rehan_khan_78):

[mediawiki/extensions/MobileFrontend@master] MobileFrontend: keep punctuation inline in headings for Parsoid

https://gerrit.wikimedia.org/r/1227820

Change #1227820 had a related patch set uploaded (by Rehan_khan_78; author: Rehan_khan_78):

[mediawiki/extensions/MobileFrontend@master] MobileFrontend: keep punctuation inline in headings for Parsoid

https://gerrit.wikimedia.org/r/1227820

cscott renamed this task from MobileFrontend + Parsoid has different HTML on en.wp main page to MobileFrontend + Parsoid has different collapsible-section HTML on en.wp main page.Thu, Jan 22, 3:27 PM

Change #1227820 abandoned by Rehan_khan_78:

[mediawiki/extensions/MobileFrontend@master] MobileFrontend: keep punctuation inline in headings for Parsoid

Reason:

i will do again with new change-Id

https://gerrit.wikimedia.org/r/1227820