The message close-all-tabs-confirmation-number is currently Close all $1 tabs?
Given that this is iOS, I'm not sure that plural can be used here. In many languages, the translation of "tabs" will be different according to the number.
Description
Description
Event Timeline
Comment Actions
Thank you for tagging this task with good first task for Wikimedia newcomers!
Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.
A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !
Thank you for helping us drive new contributions to our projects <3
Comment Actions
@Mazevedo: This does not look like a good first task as there are no pointers to docs how to fix this. Please improve the task description first; thanks.
Comment Actions
I investigated this task and found that close-all-tabs-confirmation-number exists in CommonStrings.swift and localization files, but I couldn't find any usages of the helper or localization key in the current codebase. I also noticed that close-all-tabs-confirmation-title-with-value already has proper plural support.
Could you clarify whether this task refers to an older code path, or point me to where close-all-tabs-confirmation-number is currently used?