Page MenuHomePhabricator

Unnecessary numbers are shown after some timestamps
Open, Needs TriagePublicBUG REPORT

Description

Some human timestamp messages in Hebrew are now showing unnecessary numbers after the words. For example, "1 day ago" is "לפני יום אחד (1)", so it says both the word "one" and the number "1". "Two months" ago is "לפני חודשיים (2)", where "חודשיים" already means "two months" and the number "2" is redundant.

The possible reason for the problem is this update in cldr: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/cldr/+/392a30ca2e7ede32b10b698b423e4896bb103501%5E%21/#F47

It should be fixed upstream because I'm quite sure that it's wrong for all software. Until that happens, it would be great to fix it locally in MediaWiki. I'd do it myself, but I've never tried doing it for this kind of data, so I may need assistance.

Event Timeline

@Amire80 "I'd do it myself, but I've never tried doing it for this kind of data, so I may need assistance.": Add to LocalNamesHe.php a section with an array $timeUnits = [...] and add the fix there.

Change #1227901 had a related patch set uploaded (by SarthakSingh2904; author: SarthakSingh2904):

[mediawiki/extensions/cldr@master] Fix redundant numbers in Hebrew timestamp messages

https://gerrit.wikimedia.org/r/1227901

@Amire80 "I'd do it myself, but I've never tried doing it for this kind of data, so I may need assistance.": Add to LocalNamesHe.php a section with an array $timeUnits = [...] and add the fix there.

Thanks, I'll work on that.

Change #1227901 abandoned by SarthakSingh2904:

[mediawiki/extensions/cldr@master] Fix redundant numbers in Hebrew timestamp messages

Reason:

The reviewer needed someone who had more knowledge of Hebrew

https://gerrit.wikimedia.org/r/1227901

Change #1229535 had a related patch set uploaded (by Pppery; author: Manvi Kesarwani):

[mediawiki/extensions/cldr@master] Fix Hebrew relative time strings to avoid duplicate numerals

https://gerrit.wikimedia.org/r/1229535

Change #1229535 abandoned by Manvi Kesarwani:

[mediawiki/extensions/cldr@master] Fix Hebrew relative time strings to avoid duplicate numerals

Reason:

.

https://gerrit.wikimedia.org/r/1229535