Page MenuHomePhabricator

Revise Tone UI persists brokenly after closing and reopnening the editor
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • go to a Revise Tone article
  • the highlighted section will display the warning icon (a yellow triangle) and no counter which is a correct behavior
  • without interacting with Revise tone suggestion (the highlighted section) or the revise Tone dialog - click on x button to exit the surface
  • on the same article click on the pencil button to start editing

What happens?:

  • Revise Tone UI is displayed again, maybe even multiple times

What should have happened instead?:

  • Revise Tone UI should not be displayed

Other information (browser name/version, screenshots, etc.):

Event Timeline

Change #1227859 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] fix(ReviseTone): only show it in the first edit session

https://gerrit.wikimedia.org/r/1227859

KStoller-WMF set the point value for this task to 1.

Change #1227859 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(ReviseTone): only show it in the first edit session

https://gerrit.wikimedia.org/r/1227859

Etonkovidova added a subscriber: AAlhazwani-WMF.

Checked in enwiki beta - after closing the editor and then clicking on Edit again, users will not see Revise Tone suggestions.

@AAlhazwani-WMF - can you confirm that the fix provides the desired workflow for users? For Add link there was the task - T280422: Link recommendation inspector - reloading page workflows which listed quite few possible scenarios for a users' workflows when a page is reloaded, when users switch between editors etc. In the context of Revise tone structured task do we need to maintain users' ability to return to Revise tone task?